-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2_2_2 patch #406
Merged
Merged
Release 2_2_2 patch #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got a note from Thomas that this fixed the issue with his dropbox url. |
shorowit
approved these changes
Feb 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable.
joseph-robertson
added a commit
that referenced
this pull request
Jun 4, 2020
abe59f87e Add schedule args for refrigerator, range. f8afa69be Merge branch 'master' into build-res-hpxml-v3 036948c90 Merge pull request #408 from NREL/appl-schedules 2905a5c22 Clarify that elements are on the CookingRange, not Oven, element. [ci skip] 7f7a9a5c3 Small update to docs. [ci skip] 12728f67d Update docs for optional schedules. 402655e73 Update epvalidator for optional schedules. a3ca8fdfb Remove hardcoded schedules for refrigerator, cooking range. 65f888e71 Default refrigerator, cooking range schedules. bd0821073 Add schedule fracs and mults to refrigerator, cooking range classes. a5392f2e0 Merge pull request #405 from NREL/cleanup_sample_files 4b8caa56d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into cleanup_sample_files 0459c7238 Merge pull request #406 from NREL/conditioned_ducts_lto_warning 88208ff0f Update test. b1d5070d0 Adds a warning if a HVACDistribution system has ducts entirely within conditioned space and non-zero leakage to the outside. 415dc76f8 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into cleanup_sample_files 354755974 Cleanup sample files. fd3526eda Merge pull request #403 from NREL/hp_defrost_control d5474a4bd Changes heat pump defrost control from OnDemand to Timed. git-subtree-dir: resources/hpxml-measures git-subtree-split: abe59f87e214dea8c1a4a0b34365520aba0c353b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Current curl command in datapoint init script guaranteed aws s3 downloads to work, but not downloads from other hosts (e.g., dropbox). Changing the curl command to be more generic.
Checklist
Not all may apply:
project_testing
project_testing
runs without any failuresFor more information on how to perform these checklist items, see the documentation's Advanced Tutorial.