Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2_2_2 patch #406

Merged
merged 5 commits into from
Feb 21, 2020
Merged

Release 2_2_2 patch #406

merged 5 commits into from
Feb 21, 2020

Conversation

joseph-robertson
Copy link
Contributor

Pull Request Description

Current curl command in datapoint init script guaranteed aws s3 downloads to work, but not downloads from other hosts (e.g., dropbox). Changing the curl command to be more generic.

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing (green) on circleci
  • The changelog has been updated appropriately
  • This branch is up-to-date with master

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

@joseph-robertson
Copy link
Contributor Author

I got a note from Thomas that this fixed the issue with his dropbox url.

@joseph-robertson joseph-robertson marked this pull request as ready for review February 20, 2020 16:28
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@joseph-robertson joseph-robertson merged commit b29732e into master Feb 21, 2020
@joseph-robertson joseph-robertson deleted the 2_2_1-patch2 branch February 21, 2020 17:01
@joseph-robertson joseph-robertson added this to the ResStock v2.2.2 milestone Apr 27, 2020
joseph-robertson added a commit that referenced this pull request Jun 4, 2020
abe59f87e Add schedule args for refrigerator, range.
f8afa69be Merge branch 'master' into build-res-hpxml-v3
036948c90 Merge pull request #408 from NREL/appl-schedules
2905a5c22 Clarify that elements are on the CookingRange, not Oven, element. [ci skip]
7f7a9a5c3 Small update to docs. [ci skip]
12728f67d Update docs for optional schedules.
402655e73 Update epvalidator for optional schedules.
a3ca8fdfb Remove hardcoded schedules for refrigerator, cooking range.
65f888e71 Default refrigerator, cooking range schedules.
bd0821073 Add schedule fracs and mults to refrigerator, cooking range classes.
a5392f2e0 Merge pull request #405 from NREL/cleanup_sample_files
4b8caa56d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into cleanup_sample_files
0459c7238 Merge pull request #406 from NREL/conditioned_ducts_lto_warning
88208ff0f Update test.
b1d5070d0 Adds a warning if a HVACDistribution system has ducts entirely within conditioned space and non-zero leakage to the outside.
415dc76f8 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into cleanup_sample_files
354755974 Cleanup sample files.
fd3526eda Merge pull request #403 from NREL/hp_defrost_control
d5474a4bd Changes heat pump defrost control from OnDemand to Timed.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: abe59f87e214dea8c1a4a0b34365520aba0c353b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants