Weather file update

[TobiAdekanye]

Pull Request Description

Presently, to update the weather year files, we would need to make changes to the Location Weather Filename and Location Weather Year tsvs. While this approach is fine with two weather years i.e. TMY3 and AMY weather files presently, it creates a 'ballooning' effect when one begins to add more weather years as the location weather filename tsv will need the addition of 216 EPWs to its rows and columns for each AMY year. To resolve this issue, we:

• rename all epw weather filenames such that names are consistent between all years. New location weather filename data can be found here
• delete location weather filename and location weather year as the names are now consistent between years
• update options lookup tsv by adding weather filename arguments to the location tsv
• update options lookup tsv by removing 'location weather filename' and 'location weather year' arguments

Checklist

Not all may apply:

• Unit tests have been added or updated
• All rake tasks have been run, and pass
• Documentation has been modified appropriately
• Any new options are added to project_testing
• project_testing runs without any failures
• No unexpected regression test changes
• All tests are passing (green) on circleci
• The changelog has been updated appropriately
• This branch is up-to-date with master

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

[afontani]

@TobiAdekanye @joseph-robertson Is there a more permanent place we can put these weather files other than SharePoint?

@TobiAdekanye can you also put up the TMY3 files and the testing project files in the same directory?

[joseph-robertson]

@TobiAdekanye @joseph-robertson Is there a more permanent place we can put these weather files other than SharePoint?

@TobiAdekanye can you also put up the TMY3 files and the testing project files in the same directory?

The files themselves? Or do you mean the documentation?

[afontani]

@TobiAdekanye @joseph-robertson Is there a more permanent place we can put these weather files other than SharePoint?
@TobiAdekanye can you also put up the TMY3 files and the testing project files in the same directory?

The files themselves? Or do you mean the documentation?

Sorry for the confusion, the files themselves.

[joseph-robertson]

@TobiAdekanye @joseph-robertson Is there a more permanent place we can put these weather files other than SharePoint?
@TobiAdekanye can you also put up the TMY3 files and the testing project files in the same directory?

The files themselves? Or do you mean the documentation?

Sorry for the confusion, the files themselves.

They're on data.nrel.gov. Is that what you mean? For example, here is where I patched the multifamily_beta PAT project to pull from there: https://github.com/NREL/OpenStudio-BuildStock/blob/v2.2.3/project_multifamily_beta/pat.json#L20203.

@afontani

[afontani]

@TobiAdekanye @joseph-robertson Is there a more permanent place we can put these weather files other than SharePoint?
@TobiAdekanye can you also put up the TMY3 files and the testing project files in the same directory?

The files themselves? Or do you mean the documentation?

Sorry for the confusion, the files themselves.

They're on data.nrel.gov. Is that what you mean? For example, here is where I patched the multifamily_beta PAT project to pull from there: https://github.com/NREL/OpenStudio-BuildStock/blob/v2.2.3/project_multifamily_beta/pat.json#L20203.

@afontani

That is perfect. Thanks for clarifying @joseph-robertson.

@afontani @joseph-robertson I have put up the weather files on box and modified the link above.

[afontani]

@TobiAdekanye In general, this looks pretty good. The only issue I have is that it looks like options_lookup was completely recommitted. I would prefer that the changes to the file reflect the actual changes to the file. I think what might have happened is Excel rewrote all the line endings and therefore thought that all the lines had changed.

[TobiAdekanye]

@afontani I did not recommit the options_lookup tsv, only deleted those rows i.e. location weather filename and location weather year. I am unsure how to fix this problem.

[shorowit]

Were the changes to Insulation Unfinished Attic.tsv intentional? The PR and CHANGELOG updates have no references to it.

[afontani]

@shorowit These changes were actually made by @joseph-robertson in PR #426. It seems that the changes were made by the "merge conflict fixes" commit (SHA: 3953ce5). It may be an artifact of a Merge commit of trying to update the weather-file-update branch to master, but the commit message was changed.

@TobiAdekanye can you comment on 1) how you updated the weather-file-update branch with master and 2) how you satisfied the merge conflicts?

[shorowit]

That doesn't seem right. @joseph-robertson's PR you linked to shows the Insulation Unfinished Attic.tsv gaining a new dependency (Geometry Building Type RECS), whereas this PR seems to revert that change.

[afontani]

Well, looks like I missed it during my review. I will attempt to fix this.

[afontani]

I confirmed the file was reverted to the state just before the roofing material restructure (SHA: 9c07840).