Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single-Unit Geometry #439

Merged
merged 382 commits into from
Feb 9, 2021
Merged

Single-Unit Geometry #439

merged 382 commits into from
Feb 9, 2021

Conversation

aspeake
Copy link
Contributor

@aspeake aspeake commented Apr 10, 2020 •
edited
Loading

Pull Request Description

Updates geometry measures and various measure resources to model MF and SFA homes as single units. The geometry measures now apply adiabatic boundary conditions to surfaces that would otherwise be shared in the current MF and SFA modeling approaches.

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing (green) on circleci
  • The changelog has been updated appropriately
  • This branch is up-to-date with master

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

Andrew Speake and others added 30 commits March 6, 2020 13:29
yml update on Eagle [ci skip]
afd61ae
@aspeake
add aws inputs in unit yml [ci skip]
74e3d9e
@aspeake
Merge branch 'singleunit' of github.com:NREL/OpenStudio-BuildStock in…
8dcd26a 
…to singleunit
@aspeake
new SFA geometry measure for single unit testing; pull in latest exam…
ea94eba 
…ple osws [ci skip]
@aspeake
single unit modeling capabilities for SFA homes [ci skip]
628808f
@aspeake
change how neighbor shading works with adiabatic surfaces
e51839c
@aspeake
specify mf/sfa building types when checking for single unit modeling …
3360f8e 
…approach in constructions
@aspeake
remove debug statement, add buildstockcsv files
9d185d2
@aspeake
new buildstock.csvs for sfa testing
3750903
@aspeake
fix bug in getting additional property
1e48bbb
@aspeake
checkout correct master mf geometry measure
b3f97d7
@aspeake
update error checking for invalid horz_location
1b9e240
@aspeake
update unit tests for single units
fcc4feb
@aspeake
new unit tests for MF single unit with foundation
0ad53d8
@aspeake
unit tests for MF single unit error checking
56eaecd
@aspeake
update_measures
82cec9b
@aspeake
orient gable roofs same direction for all SFA configurations
527bd3d
@aspeake
adding unit tests for single-unit modeling of SFA
636d15b
@aspeake
update_measures
f2c315d
@aspeake
regenerate_osms
ce85d2a
@aspeake
Merge branch 'master' into singleunit
af13592
@aspeake
update_measures
f715b63
@aspeake
not counting shared walls of mf/sfa in partition wall thermal mass
f9528cd
@aspeake
add back storing unit information for sfa
7cadf93
@aspeake
regenerate_osms
81429bb
@aspeake
remove singluenit testing project folder
7e48981
@aspeake
make cooridor floors adiabatic to avoid kiva errror
44c455b
@aspeake
update unit tests impacted by sfa and mf geometry changes
16dff23
@aspeake
placeholder tsvs for single unit geometry inputs
1d4192d
@aspeake
fix errors in example osws
376e1bf
joseph-robertson and others added 19 commits January 7, 2021 08:30
@joseph-robertson
Merge branch 'develop' into singleunit
d6231bf
@aspeake
clean up code, remove references to units represented
1bd87da
@aspeake
Merge branch 'singleunit' of https://github.com/NREL/resstock into si…
b0ce636 
…ngleunit
@aspeake
remove whole building MF/SFA measures used in testing
359d28e
@aspeake
regenerate test osms
c778bb5
@aspeake
Merge remote-tracking branch 'origin/develop' into singleunit
0bd1732
@aspeake
add back supplemental heating meter in reporting
a20cc9f
@aspeake
add new corridor option in rear units tsv
b650c1c
@aspeake
fix float error in tsvs
26a13b2
@aspeake
Merge remote-tracking branch 'origin/develop' into singleunit
e55fb51
@aspeake
update duct surface area tests for single unit; regenerate test osms
e49d5c2
@aspeake
fix data type error
d303a1a
@aspeake
new tests for reporting surface areas of single units
bf25abd
@aspeake
fix foundation corridor roof boundary condition
3d749d2
@aspeake
minor bug fix for MF geometry
32ce35b
@aspeake
Merge remote-tracking branch 'origin/develop' into singleunit
c9e8558
@aspeake
new buildstocks for central system testing
b62a552
@aspeake
remove central HVAC variables in reporting
16dbc54
@aspeake
remove central system variables from timeseries csv reporting
b00448f
@joseph-robertson joseph-robertson marked this pull request as ready for review February 8, 2021 18:04
@aspeake aspeake merged commit 2ee311f into develop Feb 9, 2021
@joseph-robertson joseph-robertson deleted the singleunit branch March 16, 2021 15:09
@afontani afontani mentioned this pull request Mar 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit shorowit left review comments

@joseph-robertson joseph-robertson joseph-robertson approved these changes

Assignees

@aspeake aspeake

Labels
None yet
Projects
None yet
Milestone
ResStock v2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aspeake @ejhw @shorowit @joseph-robertson