fix bug for small window areas

[aspeake]

Fixes #450

Pull Request Description

@whiphi92 uncovered a bug that would throw an error when the calculated window area of a facade was less than the minimum allowable window area. This fix checks for that case and applies the invalid window area to the largest available surface.

Checklist

Not all may apply:

• Unit tests have been added or updated
• All rake tasks have been run, and pass
• Documentation has been modified appropriately
• Any new options are added to project_testing
• project_testing runs without any failures
• No unexpected regression test changes
• All tests are passing (green) on circleci
• The changelog has been updated appropriately
• This branch is up-to-date with master

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

[aspeake]

@whiphi92 Can you test this with the ResStock project you were running previously?

[codecov-io]

Codecov Report

Merging #452 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
+ Coverage   93.43%   93.44%   +0.01%     
==========================================
  Files         168      168              
  Lines       49472    49506      +34     
==========================================
+ Hits        46223    46260      +37     
+ Misses       3249     3246       -3     

Impacted Files	Coverage Δ
measures/TimeseriesCSVExport/measure.rb	93.58% <100.00%> (+0.14%)	⬆️
...eriesCSVExport/tests/timeseries_csv_export_test.rb	99.49% <100.00%> (+0.02%)	⬆️
resources/measures/ResidentialAirflow/measure.rb	99.18% <100.00%> (-0.02%)	⬇️
...sidentialAirflow/tests/residential_airflow_test.rb	100.00% <100.00%> (ø)
...s/ResidentialGeometryWindowSkylightArea/measure.rb	95.33% <100.00%> (+0.76%)	⬆️
...indowSkylightArea/tests/WindowSkylightArea_Test.rb	99.37% <100.00%> (+0.01%)	⬆️
...esources/measures/ResidentialHVACBoiler/measure.rb	97.61% <100.00%> (+0.11%)	⬆️
...entialHVACCentralSystemBoilerBaseboards/measure.rb	97.72% <100.00%> (+0.16%)	⬆️
...res/ResidentialHVACCentralSystemFanCoil/measure.rb	98.18% <100.00%> (+0.12%)	⬆️
...asures/ResidentialHVACCentralSystemPTAC/measure.rb	97.36% <100.00%> (+0.22%)	⬆️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41ae698...b92eccc. Read the comment docs.

[whiphi92]

I re-tried the run with the same buildstock.csv and YAML file and the 3 fails I had are now successes. So looks like this fixes the bug.

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (master@357a657). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #452   +/-   ##
=========================================
  Coverage          ?   93.44%           
=========================================
  Files             ?      168           
  Lines             ?    49518           
  Branches          ?        0           
=========================================
  Hits              ?    46271           
  Misses            ?     3247           
  Partials          ?        0           

Impacted Files	Coverage Δ
...s/ResidentialGeometryWindowSkylightArea/measure.rb	95.41% <100.00%> (ø)
...indowSkylightArea/tests/WindowSkylightArea_Test.rb	99.37% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 357a657...9f6335c. Read the comment docs.

[aspeake]

@shorowit Can you take a quick look at this? We'd like to merge is asap.

[joseph-robertson]

👍