Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New stories options for MF buildings #558

Merged
merged 25 commits into from
May 11, 2021
Merged

New stories options for MF buildings #558

merged 25 commits into from
May 11, 2021

Conversation

aspeake
Copy link
Contributor

@aspeake aspeake commented Mar 22, 2021

Pull Request Description

Companion PR: resstock-estimation #100 (original PR-with discussion)
Companion PR: resstock-estimation #129 (new PR)

Removes the artificial cap of 3 stories for MF buildings, and instead uses RECS data to allow for up to 21 stories. Horizontal location and level tsvs were updated to account for the new dependencies. ResidentialGeometryCreateMultifamily was also updated for error checking and to set the Middle-level units at the halfway point. Dependency options in the Window Areas and Geometry Garage tsvs are updated as well.

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing
  • The changelog has been updated appropriately
  • This branch is up-to-date with develop

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

@aspeake aspeake requested a review from ejhw March 23, 2021 19:01
@afontani afontani marked this pull request as ready for review April 26, 2021 14:39
@aspeake aspeake requested a review from afontani May 5, 2021 16:08
@afontani afontani merged commit edda444 into develop May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants