Move HPXMLtoOpenStudio to top level #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
| arg.setDisplayName('Measures to Ignore') | ||
| arg.setDescription("Measures to exclude from the OpenStudio Workflow specified by listing one or more measure directories separated by '|'. Core ResStock measures cannot be ignored (this measure will fail). INTENDED FOR ADVANCED USERS/WORKFLOW DEVELOPERS.") | ||
| args << arg | ||
|
|
There was a problem hiding this comment.
Not even sure if/how this works with the new OS-HPXML based workflow.
| arg.setDisplayName('Annual Component Loads?') | ||
| arg.setDescription('If true, output the annual component loads.') | ||
| args << arg | ||
|
|
There was a problem hiding this comment.
These two arguments removed here since they are applicable to HPXMLtoOpenStudio.
| @@ -252,7 +237,6 @@ def run(model, runner, user_arguments) | |||
|
|
|||
| if args['os_hescore_directory'].is_initialized | |||
| os_hescore_directory = args['os_hescore_directory'].get | |||
| hes_hpxml_measures_dir = File.join(os_hescore_directory, 'hpxml-measures') | |||
There was a problem hiding this comment.
This is removed because HPXMLtoOpenStudio (not called from the measure anymore) comes after HPXMLtoHEScore and HEScoreRuleset.
| # Specify measures to run | ||
| measures['BuildResidentialHPXML'][0]['apply_defaults'] = true # for apply_hvac_sizing |
There was a problem hiding this comment.
Apply this here because ApplyUpgrade now comes before HPXMLtoOpenStudio.
aspeake
approved these changes
Sep 22, 2022
.github/workflows/config.yml
Outdated
| @@ -89,7 +89,7 @@ jobs: | |||
|
|
|||
| - name: Run buildstockbatch | |||
| run: | | |||
| pip install git+https://github.com/NREL/buildstockbatch.git@develop | |||
| pip install git+https://github.com/NREL/buildstockbatch.git@workflow-refactor | |||
There was a problem hiding this comment.
Does this automatically get reverted to develop upon merge?
There was a problem hiding this comment.
No. I'll manually revert it before merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #969.
There are slight energy differences for some datapoints. After diffing in.xml (and in.idf files), from what I can tell there are discrepancies in:
I think this is an artifact of using
collapse_enclosure_surfacesbefore defaulting (develop) vs after defaulting (feature).National project, ID=2:
develop.xml.txt
feature.xml.txt
This PR also consolidates all existing debug arguments to a single optional
debugargument stored at the top level of the YML file. For example:Checklist
Not all may apply:
openstudio tasks.rb update_measureshas been run