Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sam 313 reopt v3 for resilience #1078

Merged
merged 12 commits into from Nov 10, 2023
Merged

Sam 313 reopt v3 for resilience #1078

merged 12 commits into from Nov 10, 2023

Conversation

brtietz
Copy link
Collaborator

@brtietz brtietz commented Oct 28, 2023 •
edited

Several changes to the REopt interface including:

Pairs with SAM PR NREL/SAM#1527, see that PR for test instructions.

@brtietz
flatten reopt input dicts
aa8ac38
@brtietz
update reopt api to v3
112e91e
@brtietz
Merge branch 'develop' of https://github.com/NREL/ssc into sam_313_re…
99c99f3 
…opt_v3_for_resilience
@brtietz
correct tests since wind is no longer a required field
5cf4bd2
@brtietz
Merge branch 'develop' of https://github.com/NREL/ssc into sam_313_re…
30895a9 
…opt_v3_for_resilience
@brtietz
provide electric utility parameters to specify reopt outage
f2703aa
@brtietz
correct crit load interpretation from UI, improve invoke error handli…
b2097a2 
…ng, correct usage of outage probabilities
@brtietz
Merge branch 'develop' of https://github.com/NREL/ssc into sam_313_re…
db1ca97 
…opt_v3_for_resilience
@brtietz
Correct gen to gen_without_battery, add in grid charging variable, co…
782117a 
…rrect efficiency variables
@brtietz
document new variables
1dc1f31
@brtietz brtietz added this to the SAM Fall 2023 Release milestone Oct 28, 2023
@brtietz brtietz self-assigned this Oct 28, 2023
@brtietz brtietz mentioned this pull request Oct 28, 2023
Merged
14 tasks
cpaulgilman
cpaulgilman approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good in SSC.

May need to revise example code in PySAM documentation: https://nrel-pysam.readthedocs.io/en/main/examples.html?highlight=reopt#generate-inputs-for-a-reopt-api-call

dguittet
dguittet approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@dguittet dguittet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm also

@brtietz brtietz merged commit 916dd29 into develop Nov 10, 2023
4 checks passed
@brtietz brtietz deleted the sam_313_reopt_v3_for_resilience branch December 13, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpaulgilman cpaulgilman cpaulgilman approved these changes

@dguittet dguittet dguittet approved these changes

Assignees

@brtietz brtietz

Labels
added to release notes battery bug enhancement
Projects
None yet
Milestone
SAM Fall 2023 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brtietz @cpaulgilman @dguittet