Helpful error messages when cell temperature heat transfer method is missing data #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
than use ambient temperature
|
@cpaulgilman review for error message. |
cpaulgilman
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Looks good. Here are weather files I used for testing with heat transfer cell temp model:
weather-files-for-heat-transfer-cell-temp-tests.zip
sjanzou
requested changes
Nov 5, 2023
There was a problem hiding this comment.
Please change isnan to std::isnan throughout changes per NREL/SAM#1223
shared/lib_cec6par.cpp
Outdated
| @@ -480,6 +480,11 @@ bool mcsp_celltemp_t::operator() ( pvinput_t &input, pvmodule_t &module, double | |||
|
|
|||
| // convert to kelvin | |||
| double TA = input.Tdry+273.15; | |||
| if (isnan(input.Patm)) { | |||
There was a problem hiding this comment.
Please use std::isnan instead of isnan, see NREL/SAM#1223
shared/lib_cec6par.cpp
Outdated
| @@ -505,6 +510,11 @@ bool mcsp_celltemp_t::operator() ( pvinput_t &input, pvmodule_t &module, double | |||
| Fcs = 1. - Fcg; // !view factor between top of tilted plate and everything else (sky) | |||
| Fbs = Fcg; // !view factor bewteen top and ground = bottom and sky | |||
| Fbg = Fcs; // !view factor bewteen bottom and ground = top and sky | |||
| if (isnan(input.Tdew)) { | |||
ssc/cmod_pvsamv1.cpp
Outdated
| @@ -2188,6 +2188,7 @@ void cm_pvsamv1::exec() | |||
| tcell = Subarrays[nn]->customCellTempArray[inrec]; | |||
| else { | |||
| (*Subarrays[nn]->Module->cellTempModel)(in[nn], *Subarrays[nn]->Module->moduleModel, module_voltage, tcell); | |||
| if (isnan(tcell)) throw exec_error("pvsamv1", Subarrays[nn]->Module->cellTempModel->error()); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Throw error in pvsamv1 when ambient pressure and dew point (or wet bulb) is missing from the weather file
-Make tcell nan when this happens to make sure calculation does not continue as normal
-Fixes NREL/SAM#1428