Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marine geothermal fixes #1095

Merged
merged 8 commits into from Nov 28, 2023
Merged

Marine geothermal fixes #1095

merged 8 commits into from Nov 28, 2023

Conversation

mjprilliman
Copy link
Collaborator

-Fix geothermal variable unit change throughout code
-Update wave, tidal file readers to read location name
-Checks for non-zero bifacial ground clearance heights, update tests

@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Nov 17, 2023
@mjprilliman mjprilliman self-assigned this Nov 17, 2023
@janinefreeman janinefreeman requested review from janinefreeman and removed request for cpaulgilman November 17, 2023 16:47
@janinefreeman
Copy link
Collaborator

@cpaulgilman I'll take over this PR review

Copy link
Collaborator

@janinefreeman janinefreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be functioning correctly

@mjprilliman mjprilliman merged commit 5c55a8d into develop Nov 28, 2023
4 checks passed
@mjprilliman mjprilliman deleted the marine-geothermal-fixes branch November 28, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants