Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct size versus iprofile index for manual dispatch #1115

Merged
merged 1 commit into from Jan 26, 2024

Conversation

brtietz
Copy link
Collaborator

@brtietz brtietz commented Dec 12, 2023

Fix #1112, see issue for test instructions. Expect the two SAM cases in that file to match their dispatch output.

No milestone since it's not clear whether this will land in the release or patch 1 - for discussion at today's meeting.

@brtietz brtietz self-assigned this Dec 12, 2023
@brtietz brtietz added this to the 2023 Release Patch 1 milestone Dec 12, 2023
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

In SAM 2023.12.17, battery does not dispatch to grid in Period 6 (Jun, Jul, Aug 6am - 9am, 5pm - 6pm):

image

In SAM Open Source ssc_1112_fix_period_6_dispatch, battery does dispatch:

image

Detail:

image

@brtietz brtietz changed the base branch from develop to patch January 26, 2024 23:50
@brtietz brtietz merged commit 120ec1d into patch Jan 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuel Cell Charge Array and Battery Discharge Array ignore the value in period 6
2 participants