Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSC 720 #733

Merged
merged 3 commits into from Jan 31, 2022
Merged

Fix SSC 720 #733

merged 3 commits into from Jan 31, 2022

Conversation

brtietz
Copy link
Collaborator

@brtietz brtietz commented Jan 25, 2022

  • Initializes the demand charge used by year1_hourly_dc_with_system to zero to prevent negative values
  • Only sets values in year1_hourly_dc_peak_per_period once each month, preventing redundant values. Should now be one value per TOU period

Closes #720

@brtietz
re-initalize demand charge to 0 at the end of each month. Only assign…
3d5a0b4 
… values to dc_hourly_peak once, instead of at each new hour
@brtietz brtietz added this to the 2021.12.02 Patch 1 milestone Jan 25, 2022
@brtietz
Copy link
Collaborator Author

brtietz commented Jan 25, 2022

build-on-mac push is another one of the intermittent failures that might be related to #719. Since build-on-mac pull request passed, I'm consider that a pass of the unit tests.

cpaulgilman
cpaulgilman requested changes Jan 28, 2022
View reviewed changes
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Per #720 conversation, change label of Year 1 hourly variable "Demand charge with system" and "Demand charge without system" to "Incremental demand charge with [/without] system." This variable is helpful for understanding LCOS calculation and price signal dispatch.

@brtietz brtietz merged commit 4e6a8ac into patch Jan 31, 2022
@brtietz brtietz deleted the fix_ssc_720 branch February 9, 2022 18:12
@brtietz brtietz mentioned this pull request Feb 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpaulgilman cpaulgilman cpaulgilman approved these changes

Assignees
No one assigned
Labels
added to release notes bug utility rate
Projects
None yet
Milestone
2021.12.02 Patch 1
Development

Successfully merging this pull request may close these issues.

Electricity peak demand charges produce negative numbers, and don't correlate with peak from grid output
2 participants
@brtietz @cpaulgilman