PV temperature updates in ssc #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outputs to test in parametrics
(code takes 25 minutes and fails)
unused in/outputs from pvsamv1
cpaulgilman
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
I did a basic pvsamv1 test with the CEC module model in SDKtool to confirm that setting time series cell temp as input does affect the cell temp output, and to confirm that this option is not accessible from the SAM UI, even via LK.
I thought subarray1_celltemp output would be equal to the measured_temp_array input, but it isn't -- not sure what to expect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Option to input module temperatures instead of using temperature models (length nrecs per year)
-Option to use lacunarity heat transfer model (University of Utah, Portland State University, NREL) when using the heat transfer model option
-SAM user interface updates to come in patch or future release
-Partially addresses NREL/SAM#106 (on SDK/PySAM side for now)