Establish tests and clarify naming #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpute_controls, respectively, for generality.
… controlller/interface for current compatibility with Hercules.
This was referenced Dec 21, 2023
Merged
achenry
pushed a commit
to achenry/wind-hybrid-open-controller
that referenced
this pull request
Apr 22, 2024
* Testing interface_base. * Remove repeated class definition. * renaming send_setpoints and compute_setpoints to send_controls and compute_controls, respectively, for generality. * Move controller_base into controllers/ directory. * Beginning to build out interface library tests. * Updating to check_controls. * setpoints -> controls for dicts. * Test imports, methods implemented. * Tests for HerculesADYawInterface. * Explicit dictionary input. * Simplified tests for HerculesWindBatteryInterface * Ruff. * Inheritance tests. * Beginnings of controller library test. * Improved developer installation instructions. * Add note for future test for HerculesWindBatteryController. * Ruff. * Add zmq to requirements. * Reverting some changes from setpoints to controls in the wind battery controlller/interface for current compatibility with Hercules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests implements tests for the
InterfaceBaseandControllerBaseclasses as well as beginning to build out tests for the otherInterfaceandControllerobjects.In addition, verbiage regarding "setpoints" was changed to "controls" for generality, causing changes throughout the code. It is expected that this may cause some minor issues with the Hercules repository, which will be investigated before this is merged.
Addresses #11