Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CancellationToken #223

Merged
merged 1 commit into from
May 4, 2020
Merged

Support CancellationToken #223

merged 1 commit into from
May 4, 2020

Conversation

a046
Copy link
Contributor

@a046 a046 commented May 2, 2020

Handle #221 architecturally, support CancellationToken in Fire, Actions and Compile.

Not sure about adding it to InsertAll, thoughts?

@snikolayev snikolayev added this to the 0.9.1 milestone May 4, 2020
@snikolayev snikolayev merged commit c2fa21b into NRules:develop May 4, 2020
@snikolayev
Copy link
Member

@a046 thank you.
Regarding session insert/update/retract, I don't think cancellation there is helpful or needed. If you cancel propagation of facts in the middle, it would leave the session in an invalid state.

@a046
Copy link
Contributor Author

a046 commented May 4, 2020

Thanks @snikolayev, I was more thinking about the initial seeding of the session with facts (particularly if something like #224 occurs). But it can handled by the consuming code by batching the calls to InsertAll which avoids the complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants