Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#62 - optional voice output feature in calculator module #64

Merged
merged 3 commits into from
Oct 14, 2019

Conversation

sanket099
Copy link
Contributor

@sanket099 sanket099 commented Oct 13, 2019

changes made w.r.t issue #62

fixes #62

@sanket099 sanket099 mentioned this pull request Oct 13, 2019
Copy link
Member

@Swati4star Swati4star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can make changes in this PR only. No need to create a new PR

voice_icon.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View view) {
if (voice_icon_status==1){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add space before and after ==

@Override
public void onClick(View view) {
if (voice_icon_status==1){
voice_icon_status=0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at all places

}
}
});
if (voice_icon_status==1){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here also

@Swati4star Swati4star changed the title New branch #62 - optional voice output feature in calculator module Oct 14, 2019
@Swati4star Swati4star merged commit b819206 into NSITonline:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Feature suggestion : optional voice output feature in calculator module
2 participants