Perform unit tests in NSLS-II conda environments #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@padraic-shafer do you want a review or merge? |
|
Yes, please. If it looks good to you, please merge. |
ambarb
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
@padraic-shafer this looks pretty standard. I do hope there is a template for this that is in a custom nsls-ii cookie-cutter like thing. Is that right, or was this a lot of custom work?
|
I'll merge after i check the other one and then try to run the test suite "as a developer" to make sure I don't have questions. I followed instructions from skbeam. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub action to run unit tests in recent NSLS-II conda environments.
recent-envs.yml.legacy-envs.ymlcan be run from the workflow defined inlegacy-conda-env-tests.ymlUnit tests currently pass in all 36 environments from 2023 + 2024 without modifications, so long as two other recent PRs are merged into the test environment.
PRs #94, #95, #96 can be merged in any order.