Fix startup error when databroker is not present on HXN/CSX machines #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrakitin
reviewed
Feb 14, 2020
nsls2ptycho/core/databroker_api.py
Outdated
| try: | ||
| import nsls2ptycho.core.HXN_databroker as hxn_databroker | ||
| except ImportError: | ||
| raise RuntimeError("[WARNING] Databroker is not found and so disabled.") |
There was a problem hiding this comment.
I think it should have a type of "Error" as it's rising. Same below.
Suggested change
| raise RuntimeError("[WARNING] Databroker is not found and so disabled.") | |
| raise RuntimeError("[Error] Databroker is not found and so disabled.") |
There was a problem hiding this comment.
Thanks Maksim! It's better be a warning I think, because this "error" is immediately caught by the outer try-except and simply printed (at the start time of GUI):
ptycho_gui/nsls2ptycho/core/databroker_api.py
Lines 73 to 74 in dbb3c87
Databroker is not a hard dependency after all.
|
The fix is simplified: We just need to catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #73. See #73 (comment) for a reproducer.