New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: first pass at ingesting nexus files #28
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 96.38% 90.28% -6.11%
==========================================
Files 5 6 +1
Lines 858 916 +58
==========================================
Hits 827 827
- Misses 31 89 +58
Continue to review full report at Codecov.
|
How do we test this ? Wouldn't we need to store the My first reaction is that we should change the name as it is for a very specific |
Based on chopper.nxs from nexpy examples
81cbbf8
to
f9042fa
Compare
What are the application names from the chopper file and the format that Pete wrote? |
@prjemian Just wondering on your thoughts about the suggestion to 'partition' the NeXus code by application definition type ? Does that seem sensible ? If so, what IDF does your file correspond to ? |
I don't understand idf type, yet. Can you help me there?
…On May 2, 2017 3:37 PM, "Stuart Campbell" ***@***.***> wrote:
@prjemian <https://github.com/prjemian> Just wondering on your thoughts
about the suggestion to 'partition' the NeXus code by IDF type ? Does that
seem sensible ? If so, what IDF does your file correspond to ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACLKMO6ZsetQD_O7pGjZxiTMSgPTn_o9ks5r15PqgaJpZM4MReCd>
.
|
Sorry @prjemian I mistyped! I mean the application definition ? |
I believe I was shooting for a plain NXentry group with NXinstrument subgroup and linked content in NXdata group. There is no application definition now that is sufficiently generic. We could create our own application definition and that may be useful to give a defined interface. Comments? |
I must admit this was part of my fiendish plan was to make this type of file a new nexus definition. I don't think we need to have a hard/strict format yet (as it is bound to change as we learn more) but any suggestions on a name ? |
First idea: NXbluesky (as NXsuitcase seems suggestive yet so non-descriptive) |
Here is the initial NeXus schema (from the source code):
But that needs improvement as begin to better understand what information is standard in the |
return v | ||
|
||
|
||
def injest_nexus(fname): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be ingest_nexus
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@klauer and @danielballan have already thoroughly pointed out this error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry - didn't notice and couldn't find their comments.
Based on chopper.nxs from nexpy examples
attn @stuartcampbell