Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support change detection #9

Closed
minecrawler opened this issue Nov 4, 2019 · 3 comments
Closed

Support change detection #9

minecrawler opened this issue Nov 4, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@minecrawler
Copy link
Collaborator

Fire events when components are created, components are added/removed and deleted.
@minecrawler minecrawler added enhancement New feature or request good first issue Good for newcomers labels Nov 4, 2019
@minecrawler minecrawler added this to the 1.0 milestone Nov 4, 2019
@minecrawler
Copy link
Collaborator Author

I guess I should change the scope to add/remove, because that's the only thing we can detect on an entity.

@minecrawler minecrawler removed the good first issue Good for newcomers label Sep 29, 2020
@minecrawler
Copy link
Collaborator Author

minecrawler commented Jul 16, 2021 •
edited

Now tracked on Kanban:

minecrawler added a commit that referenced this issue Feb 24, 2022
@minecrawler
#9 implement entity add/removal events
c8a3e48
minecrawler added a commit that referenced this issue Feb 24, 2022
@minecrawler
#9 implement entity add/removal events
d3b579f
@minecrawler minecrawler mentioned this issue Nov 3, 2022
Open
@minecrawler minecrawler modified the milestones: 1.0, 0.6.1 Dec 3, 2022
@minecrawler minecrawler removed this from the 0.6.1 milestone May 21, 2023
minecrawler added a commit that referenced this issue Jul 4, 2023
@minecrawler
#9 prepare eventing and implement it for resource adding and PDA
ae28821
minecrawler added a commit that referenced this issue Jul 5, 2023
@minecrawler
#9 implement entity add/remove events
655fdcf
minecrawler added a commit that referenced this issue Jul 5, 2023
@minecrawler
#9 prepare eventing and implement it for resource adding and PDA
d910531
minecrawler added a commit that referenced this issue Jul 5, 2023
@minecrawler
#9 implement entity add/remove events
68a9edd
minecrawler added a commit that referenced this issue Jul 5, 2023
@minecrawler
#9 emit resource-add event
8fd9d85
minecrawler added a commit that referenced this issue Jul 5, 2023
@minecrawler
#9 change entity event names to be more in line with the rest
a196eff
minecrawler added a commit that referenced this issue Jul 5, 2023
@minecrawler
#9 implement remove-resource-event
9ebc129
minecrawler added a commit that referenced this issue Jul 7, 2023
@minecrawler
#9 implement component and tag events (not on per-field-base)
c0a2fb2
@minecrawler
Copy link
Collaborator Author

minecrawler commented Jul 7, 2023 •
edited

So I tested field-based changes, and while JS is a wonderful unicorn chewing gum and I can easily implement it, the performance is actually very bad (using Object.defineProperty.set) - especially for continually changing fields. Even if I create a wrapper which can be applied only to interesting components, it's bad. Iteration is faster if you just copy values over in a system, so that's what I recommend to do. Don't wait for mutation, just copy it.

With that, change events are handled. That's one of my oldest tickets, so cheers to closing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@minecrawler