Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

Update draft-ietf-tcpm-rfc8312bis.md #131

Merged
merged 6 commits into from
Nov 11, 2021
Merged

Conversation

gorryfair
Copy link
Contributor

This PR is intended to amend the text to align with my understanding of the RFC-series. This normatively would require ssthresh to be set from flight_size; however, this is explicitly relaxed in RFC7661, so I suggest wording should be careful around this topic. I retained the original text observation that in fact some cubic implementations are known to set ssthresh from cwnd.

Note: I expected the REF to "RFC7661" to be informative (EXP).

@gorryfair
Copy link
Contributor Author

See #132.

draft-ietf-tcpm-rfc8312bis.md Outdated Show resolved Hide resolved
draft-ietf-tcpm-rfc8312bis.md Outdated Show resolved Hide resolved
draft-ietf-tcpm-rfc8312bis.md Outdated Show resolved Hide resolved
@larseggert
Copy link
Contributor

Does this mean that we don't need to update 5681 anymore, because 7661 OK'ed CUBIC's behavior? Should 7661 have updated 5681?

Copy link
Contributor

@larseggert larseggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix Markdown nits and add changelog entry.

@gorryfair
Copy link
Contributor Author

The issue I think is: RFC 7661 describes a framework for application-limited flows to determine an appropriate cwnd. It's a relaxation with caveats also about how a flow needs to behave when an "unvalidated" use of cwnd was not safe (i.e. the "normal" case of using cwnd proved to be unsafe). RFC 7661 could have been a PS and could have updated 5681 - at the moment neither is the case. As far as I know, some Cubic implementations do part of what RFC 7661 says, and others might do all. The final sentence of the suggested PR acknowledges this, without trying to interpret this, seeking to avoid blocking publication of this specific PS.

I'll re-echo your question to others: Should 7661 have updated 5681? Should it become PS?

@larseggert
Copy link
Contributor

I'll re-echo your question to others: Should 7661 have updated 5681? Should it become PS?

At the moment, this document is intending to update 5681 to allow CUBIC's behavior. Since that is on the "extreme" side of what 7661 allowed, maybe 7661 should?

@larseggert
Copy link
Contributor

This still needs a changelog entry, but is otherwise good to go.

@goelvidhi goelvidhi linked an issue Nov 9, 2021 that may be closed by this pull request
@larseggert
Copy link
Contributor

@gorryfair please add a changelog line.

@gorryfair
Copy link
Contributor Author

@larseggert @goelvidhi Happy for someone to add a changeling entry.

gorryfair and others added 5 commits November 9, 2021 12:51
Take 2 at a PR is intended to amend the text to align with my understanding of the RFC-series. This normatively  would require ssthresh to be set from flight_size; however, this is explicitly relaxed in RFC7661, so I suggest wording should be careful around this topic. I retained the original text observation that in fact some cubic implementations are known to set ssthresh from cwnd.
remove whitespace

Co-authored-by: Vidhi Goel <goel.vidhi07@gmail.com>
That's OK

Co-authored-by: Vidhi Goel <goel.vidhi07@gmail.com>
I think this may be obvious from the preceding section, but it seems technically more correct, so I'll commit this.

Co-authored-by: Vidhi Goel <goel.vidhi07@gmail.com>
Now able to edit.  md file fixed to remove trailing whitespace.
@larseggert larseggert merged commit 6539c0e into NTAP:main Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion to avoid long discussion on RFC7661 and cwnd v flight_size
3 participants