Fix for OS other than Windows (Linux tested) & cmake #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code had to be fixed do compile on other OS than Windows. Some small changes also had to be applied to have correct results on other OS. - the '\' had to be replaced by '/' in #include, the latter being valid on both Windows and Linux (and Mac, and ...) OS - the "_copysign" function is "copysign" for non Windows OS - the use of "abs" is code led to bad results (it would convert double to integers instead of taking absolute values), it's been replace by "fabs"
Tested on both Windows (Visual Studio projects) and Linux (makefiles for gcc). With the code fixes, the results are identifical on both OS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial code would not compile on Linux, so a few change had to be done. Furthermore, even after initial changes to be able to compile, and extra fix had to be done to get correct results.
A CMakeLists.txt file for CMake has also been added to generate static or shared library on both Windows and Linux.
Tested on both Windows and Linux.