Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate WebRelay class and provide status #11

Merged
merged 36 commits into from
Aug 26, 2022
Merged

Separate WebRelay class and provide status #11

merged 36 commits into from
Aug 26, 2022

Conversation

dboulware
Copy link
Contributor

The purpose of this PR is to make changes that will allow sensors to have a preselector and multiple switches (web relays). To accomplish this, it:

  • Provides an abstract WebRelay class
  • Provides a ControlByWeb based implementation of the WebRelay class
  • Modifies the WebRelayPreselector to use the WebRelayClass
  • Adds status and name method and property to Preselector and WebRelay
  • Modifies config to separate control from status to support the status method and reconfigurable status.
  • Modifies preselector control to use rf_path names in utility methods.
  • Modifies ControlByWebWebRelay and WebRelayPreselector to require name and base_url.
  • Adds docstrings and type hints
  • Adds changes from Update backend #10 (comment)

dboulware and others added 28 commits August 4, 2022 08:32
@dboulware
Separate web relay into its own class and use it within the WebRelayP…
4ea2fca 
…reselector.
@dboulware
Modified config to include name, and control_states and status_states…
af899a9 
… sections to support configurable status requests. Added id and name properties and get_status method to preselector and web_relay interfaces.
@aromanielloNTIA
Switch to flit backend
ebfb521
@aromanielloNTIA
README cleanup + add badges
c868d62
@aromanielloNTIA
Moved tests outside of src
54c1ee6
@aromanielloNTIA
Added pre-commit configuration
4b64870
@aromanielloNTIA
Fix typo
5d5e155
@aromanielloNTIA
Add pytest-cov dev dependency
c4b9fb7
@aromanielloNTIA
Include docs in sdist
d917f7b
@aromanielloNTIA
Update README
a9d1d3e
@aromanielloNTIA
Update example config
d66ab1a
@aromanielloNTIA
pre-commit run on all files
b2e89ed
@dboulware
Set timeout to 1 second when querying for switch state.
f9193cb
@aromanielloNTIA
Revert "pre-commit run on all files"
efda2a9 
This reverts commit b2e89ed.
@aromanielloNTIA
Merge branch 'WebRelayAndStatus' into update-backend
6bcf3f6
@dboulware
replace web_relay_healthy with healthy.
0f9c8aa
@aromanielloNTIA
Switch to Hatchling
d80ca33
@aromanielloNTIA
Merge branch 'WebRelayAndStatus' into update-backend
65a8d89
@dboulware
Add name to controlbyweb_web_relay status.
3f01ebb
@aromanielloNTIA
Add links to table of contents && git push origin update-backend
bb6abf5
@aromanielloNTIA
Merge branch 'WebRelayAndStatus' into update-backend
63c5b0b
@dboulware
debug
9bd52ef
@aromanielloNTIA
Merge branch 'WebRelayAndStatus' into update-backend
38a5da6
@dboulware
Remove extraneous comma in example config. Add type hints and docstri…
1cf9515 
…ngs. Change rf_paths to dictionary and use rf_path names for interactions.
@dboulware
Require base_url and name in ControlByWebWebRelay and WebRelayPresele…
2f93eeb 
…ctor by association.
@dboulware
Merge branch 'WebRelayAndStatus' of https://github.com/NTIA/Preselector…
34b1905 
… into update-backend
@dboulware
Merge pull request #10 from NTIA/update-backend
4e76a2d 
Update backend
@dboulware
Fix readme after merge and increment version.
0ad1079
aromanielloNTIA
aromanielloNTIA reviewed Aug 23, 2022
View reviewed changes
Copy link
Member

@aromanielloNTIA aromanielloNTIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good-see comments

.pre-commit-config.yaml Show resolved Hide resolved
src/its_preselector/controlbyweb_web_relay.py Outdated Show resolved Hide resolved
src/its_preselector/controlbyweb_web_relay.py Outdated Show resolved Hide resolved
src/its_preselector/preselector.py Show resolved Hide resolved
src/its_preselector/preselector.py Show resolved Hide resolved
src/its_preselector/preselector.py Show resolved Hide resolved
src/its_preselector/preselector.py Show resolved Hide resolved
src/its_preselector/preselector.py Show resolved Hide resolved
src/its_preselector/web_relay.py Show resolved Hide resolved
tests/test_controlbyweb_web_relay.py Outdated Show resolved Hide resolved
aromanielloNTIA
aromanielloNTIA approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@aromanielloNTIA aromanielloNTIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dboulware dboulware merged commit b954743 into master Aug 26, 2022
@dboulware dboulware deleted the WebRelayAndStatus branch November 30, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aromanielloNTIA aromanielloNTIA aromanielloNTIA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dboulware @aromanielloNTIA