Analog inputs and add sensors, digital inputs, and analog inputs to configuration #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aromanielloNTIA
requested changes
Nov 29, 2023
| }, | ||
| "digital_inputs": { | ||
| "ups_power": 1, | ||
| "ups_battery_level": 2, |
There was a problem hiding this comment.
Recommend changing "ups_battery_level" to a better descriptor like "ups_battery_low"
Also update the example in the README for any change made.
README.md
Outdated
| @@ -88,6 +107,11 @@ those specified in the mapping. Each of the entries in the config provide mappin | |||
| associated web relay input states and every RFPath defined in the sensor definition json | |||
| file should have an entry in the preselector config. The keys in the dictionary may use the | |||
| name of the RFPath or the index of the RFPath in the RFPaths array. | |||
| The `sensors`, `digital_inputs`, and `analog_inputs` keys define the sensors, | |||
| digital_inputs and analog_inputs configured on the device. Within each of the sections, | |||
There was a problem hiding this comment.
Recommend checking this paragraph for consistent usage of monospace formatting
… inputs. Add tests for get_sensor_value and get_digital_input_value. Correct type hint. Update readme.
…well and update README.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to read analog inputs from the controlbyweb web relays. In addition, this allows users to map sensors, digital inputs and analog inputs into to the configuration. Any sensors, digital inputs, and analog inputs will be provided in calls to get_status.