Support X410 sensor format and allow for instantiation from just sensor definition json. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold on, need to check version. |
Minor improvement to file loading: see [PEP 343](https://peps.python.org/pep-0343/) - this syntax adds a built-in `try:`/`finally:` statement around the `json.load()` call, which ensures the file is closed. This is a more robust way to implement the file load, especially valuable for open source code which may be subject to more modifications in the future. Also see [this](https://thispointer.com/python-open-a-file-using-open-with-statement-benefits-explained-with-examples/) page for more practical examples motivating this syntax.
aromanielloNTIA
requested changes
May 31, 2022
There was a problem hiding this comment.
Approved, pending:
- I added a syntax improvement in 0756667, which should get review from @dboulware (should be fine, no functional change).
- Need to re-add
config/config.jsonfile which was deleted. - Address other comments left above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the X410 xml format when reading sensor values and allows the preselector to be instantiated from just the sensor definition portion of SigMF because that is the format of the file that is deployed to scos-sensor (see https://github.com/NTIA/scos-sensor-cm/blob/master/sensor_definitions/default_sensor_definition.json) for example.