Wait until db ready #231
Merged
Wait until db ready #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_until_db_ready
…t_until_db_ready
…t_until_db_ready
…t_until_db_ready
…t_until_db_ready
dboulware
requested changes
Mar 13, 2024
dboulware
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request configures the api container to wait to start until the database container is healthy.
It looks like docker-compose v2 is needed unless using an old version of docker (then latest docker-compose v1 might work).
Not sure if the database error is still reproducible. But testing with this branch, I did not see any errors for the following:
Also includes a small change to create_localhost_cert.sh to combine the cp/mv commands.