Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debugging tools for ray and segmentation faults #245

Merged
merged 27 commits into from
Jun 30, 2023

Conversation

aromanielloNTIA
Copy link
Member

@aromanielloNTIA aromanielloNTIA commented Jun 26, 2023

EDIT: Converted to draft PR while using this branch for testing.

  • Enable Ray CLI tools from ray[default] when running SCOS Sensor in DEBUG mode
  • Enable the Python faulthandler in DEBUG mode to produce full tracebacks for SIGSEGV, SIGFPE, SIGABRT, SIGBUS, and SIGILL signals
  • Update pre-commit hooks and run on all files (including "--py38-plus" flag for pyupgrade, which results in changes to formatted strings)

@aromanielloNTIA aromanielloNTIA marked this pull request as draft June 26, 2023 16:02
@aromanielloNTIA aromanielloNTIA self-assigned this Jun 29, 2023
@aromanielloNTIA aromanielloNTIA marked this pull request as ready for review June 29, 2023 15:10
@aromanielloNTIA aromanielloNTIA merged commit eb4be4d into master Jun 30, 2023
4 checks passed
@aromanielloNTIA aromanielloNTIA deleted the ray-and-segfault-debugging branch June 30, 2023 15:01
aromanielloNTIA added a commit that referenced this pull request Jun 30, 2023
commit eb4be4d
Author: Anthony Romaniello <66272872+aromanielloNTIA@users.noreply.github.com>
Date:   Fri Jun 30 09:01:08 2023 -0600

    Improve debugging tools for `ray` and segmentation faults (#245)

    * testing branches for scos-actions and scos-tekrsa

    * record Ray reference creation sites in debug mode

    * start ray dashboard in debug mode

    * use faulthandler in debug mode

    * Compile deps

    * remove ray init from scheduler

    * decrease ray version

    * Update Ray to 2.4.0

    * tagged versions of actions and tekrsa

    * increase sleep time before CI container health check

    * try 60s wait for API container test

    * do not use grep quiet option

    using "-q", grep always has an exit status of 0. Without this flag, exit status is only 0 if a line is selected by grep

    * update pre-commit hooks

    * run pre-commit hooks on all files

    * use sea-prototype-v0.4.1 tags

    * recompile requirements

    * update markdownlint hook

    * revert unnecessary GH actions workflow changes

    * Bump minimum ray debug version to match scos-actions

    * Increase wait for container healthy time in GH Action

    * update scos-actions branch for testing

    * update scos-tekrsa version for testing

    * update requirements

    tagged scos plugin versions, other minor updates

commit f2de439
Author: Anthony Romaniello <66272872+aromanielloNTIA@users.noreply.github.com>
Date:   Fri Jun 23 10:07:04 2023 -0600

    Update SCOS Actions for SigMF-NS-NTIA updates (#244)

    * testing update-sigmf-ns-ntia

    * Update sensor_definition.json

    * remove pywin dev requirement for linux testing

    * update requirements (add msgspec)

    * update pre-commit version

    * Update measurement_handler.py

    * revert attribute check to key check

    * do not overwrite sensor ID with FQDN

    * Remove old, unused schemas

    * remove sample count check

    this is no longer possible from the metadata, and the sha512 check makes it redundant

    * update requirements

    tagged releases for scos-actions and scos-tekrsa

    * increase wait time for container healthy in CI tests

commit 78732f2
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Jun 6 15:53:03 2023 -0400

    Bump cryptography from 39.0.1 to 41.0.0 in /src (#243)

    * Bump cryptography from 39.0.1 to 41.0.0 in /src

    Bumps [cryptography](https://github.com/pyca/cryptography) from 39.0.1 to 41.0.0.
    - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
    - [Commits](pyca/cryptography@39.0.1...41.0.0)

    ---
    updated-dependencies:
    - dependency-name: cryptography
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

    * Update requirements.in and run pip-compile

    ---------

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Anthony Romaniello <aromaniello@ntia.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants