-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public release of SCOS Tektronix RSA plugin #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tektronix RSA 500/600 Series Support
Updated documentation to reflect renaming of master branch to 'main' per GitHub recommended practices prior to public release
aromanielloNTIA
requested review from
MichaelCotton,
dboulware and
jhazentia
February 14, 2022 18:19
Removed instructions for supplying GitHub login details to SCOS, which will not be required upon public release.
MichaelCotton
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked documentation, which looks clean bug-free and ready for release. Good work @aromanielloNTIA.
jhazentia
reviewed
Aug 1, 2022
jhazentia
reviewed
Aug 1, 2022
jhazentia
reviewed
Aug 1, 2022
lsegreNTIA
reviewed
Aug 3, 2022
lsegreNTIA
reviewed
Aug 3, 2022
lsegreNTIA
reviewed
Aug 3, 2022
lsegreNTIA
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved subject to suggested edits.
jhazentia
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README instructions have been updated for public release.
After approval, these commits will be merged into the
main
branch and the repository will be made public.The
main
branch will be tagged v1.0.0 upon the repository being made public.