-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce level of many log messages #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboulware
reviewed
Oct 24, 2023
dboulware
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest changing the overload logging to debug.
Is there a reason this is marked as draft? |
Nevermind. I suspect it is because it is waiting on scos-actions PR. |
dboulware
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces lots of info- and warning-level logs to debug level. Now, everything is debug level, except:
Error/Exception Level:
discover/__init__
is unable to determine the RSA modelhardware/__init__
is unable to initialize the signal analyzer interface, andsigan
is set toNone
__init__
fails and sigan power cycling is triggeredValueError
)ValueError
)connect()
method fails to find and/or connect to the signal analyzer (also raises an exception)tekrsa-api-wrap
API wrapper cannot be loaded and the signal analyzer is disabled (also raisesImportError
)Warning Level:
sigan
isNone
while attempting to discover actions (indiscover/__init__
)connect()
method of the signal analyzer interface when using a mock signal analyzerInfo Level:
acquire_time_domain_samples
)Bumps patch version to 3.1.5