Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce level of many log messages #49

Merged
merged 7 commits into from
Oct 27, 2023
Merged

Conversation

aromanielloNTIA
Copy link
Member

@aromanielloNTIA aromanielloNTIA commented Oct 24, 2023

Reduces lots of info- and warning-level logs to debug level. Now, everything is debug level, except:

Error/Exception Level:

  • When discover/__init__ is unable to determine the RSA model
  • When hardware/__init__ is unable to initialize the signal analyzer interface, and sigan is set to None
  • When the signal analyzer interface __init__ fails and sigan power cycling is triggered
  • When an attempt is made to set the sampling rate to an invalid value (also raises ValueError)
  • When an attempt is made to set the IQ bandwidth to an invalid value (also raises ValueError)
  • When the signal analyzer interface connect() method fails to find and/or connect to the signal analyzer (also raises an exception)
  • When the tekrsa-api-wrap API wrapper cannot be loaded and the signal analyzer is disabled (also raises ImportError)

Warning Level:

  • When sigan is None while attempting to discover actions (in discover/__init__)
  • From the connect() method of the signal analyzer interface when using a mock signal analyzer

Info Level:

  • When data loss occurs during IQ streaming and a retry is triggered (in acquire_time_domain_samples)

Bumps patch version to 3.1.5

@aromanielloNTIA aromanielloNTIA marked this pull request as ready for review October 24, 2023 15:47
Copy link
Collaborator

@dboulware dboulware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing the overload logging to debug.

@aromanielloNTIA aromanielloNTIA marked this pull request as draft October 25, 2023 17:19
@dboulware
Copy link
Collaborator

Is there a reason this is marked as draft?

@dboulware
Copy link
Collaborator

Nevermind. I suspect it is because it is waiting on scos-actions PR.

@aromanielloNTIA aromanielloNTIA marked this pull request as ready for review October 26, 2023 15:46
@aromanielloNTIA aromanielloNTIA merged commit f0f77a6 into main Oct 27, 2023
@aromanielloNTIA aromanielloNTIA deleted the minimize-non-debug-logging branch October 27, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants