Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calibration defaulting #2

Merged
merged 6 commits into from Jun 30, 2020
Merged

Fix calibration defaulting #2

merged 6 commits into from Jun 30, 2020

Conversation

ToddSchumannNTIA
Copy link
Contributor

Fixes an issue where the sensor calibration values would not properly default to the sigan values when using an empty or sparse sensor calibration file.

  • Added fix
  • Added additional pytest for this situation

Example empty calibration matrix:

            10e6: {  # Sample rate
                1e9: {  # Center frequency
                    40: {},  # Gain setting and empty calibration dict
                    60: {}
                },
                2e9: {
                    40: {},
                    60: {}
                }
            }
        }

Original issue description:
When using an empty calibration file or a file where not all values are specified, scos-sensor will correctly load the file, which prevented reloading the values to be overwritten into the currect calibration dict (set in recompute_calibration_data in usrp_radio.py). When retuned, the values from the previous tuning were never overwritten from the defaulting values, so new default values were not used.

@jhazentia jhazentia merged commit 4cb7ef0 into master Jun 30, 2020
@jhazentia jhazentia deleted the fix-calibration-defaulting branch June 30, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants