New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded Examine Experiment [DO NOT MERGE] #853
base: master
Are you sure you want to change the base?
Conversation
…three paragraphs, including light-blue 'tutorial' lines and a golden fluff text line. It is in it's own window to not clutter up the chat box. New vars: desc_info , desc_fluff . Fill them out!
@@ -2157,9 +2159,11 @@ window "infowindow" | |||
tab-font-family = "" | |||
tab-font-size = 0 | |||
tab-font-style = "" | |||
allow-html = false | |||
allow-html = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm, what's going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, HTML in stat panels doesn't get parsed. Changing this shouldn't cause any issues since I don't think people would write in html if they didn't want to, and the worse outcome is colored text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I was afraid this let people do, Worst outcome is coloured text? If it allows HTML for coloured text, it allows Scripts to be injected leading to all sorts of exploits.
I can't allow this. This has the potential to be DANGEROUS. To the players online, and to SoS.
You will find a different way to display your text without using HTML or this experiment ends here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ yes this html exploits are super easy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this vulnerability already exist as the output box supports HTML?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which output box?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main chat one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as I said in the IRC last night, I believe that's setup to strip HTML.
I really don't like usr. but hey. |
muh fluff |
This morning I investigated tooltips. Turns out, they technically are possible, but maptext ruins everything and it would look like ass and be shitty if you needed anything beyond a few words.
So I thought to myself, what could replace a tooltip? And here we are.
This introduces a new tab, which is updated whenever you examine something normally.
It looks like this.
http://puu.sh/aj4EX/eeb58c0085.png
Blue line is for 'instructions' or tips, primarily aimed at new players.
The gold line is for fluff, if you want. Go nuts, write paragraphs, as this is optional to read, in it's own tab and it won't clutter up the text.
You just need to add desc_info or desc_fluff and of course a string for it.
This is probably done poorly but it's more of an experiment then a feature right now.
Unfortunately there's a ton of writing to do to make this worthwhile but at least the framework is there!
(also if anyone can help me make it not use mob verbs to hold onto the thing, let me know.)