Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaling of y changed after ToolBox.get_query_strategy(strategy_name='QueryInstanceBMDR', kernel='rbf') #33

Closed
lukekolbe opened this issue Jun 23, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@lukekolbe
Copy link

lukekolbe commented Jun 23, 2021

When loading both strategies that use cvxpy, the values of ToolBox._y change from (0, 1) to (-1, 1). Since the ToolBox object does not create a copy but instead only stores a reference to y, the actual values in y are changed as well. Other strategies in query_labels.py do not display such behavior.

This to me seems problematic, as the original data should not be changed. It is also a problem because if you run several models from the same ToolBox object, that object in general should not change between models.

See screenshot for quick demonstration, the data is split in X and y, both np.arrays. Y is either 0 or 1 (see printouts).

I use colab, so the alipy version is always freshly installed.

Bildschirmfoto 2021-06-23 um 14 01 35

@tangypnuaa tangypnuaa added the bug Something isn't working label Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants