Ad 2

[calavera]

This is a rebound of #14 with the log fixed.

The problem was that the method that checks if the log line is an error assumed that every line without a logging header came from an error. That's not true in cases like when a schema is being loaded, which is only info:

"INFO: Loading other enabled schema: \n"
"\tSchema Name: other\n"
"\t\tDisabled: false\n"
"\t\tOwner: uid=admin,ou=system\n"
"\t\tDependencies: [system, apachemeta, apache, core]\n"

Tests pass and there are no weird messages now:

calavera@dcp ~/oss/ladle (ad_2●)$ rake spec
Compiling java support code
/Users/calavera/oss/ladle/lib/ladle/apacheds/apacheds-service-2.0.0-M15.jar(org/apache/directory/api/ldap/model/name/Dn.class): warning: Cannot find annotation method 'value()' in type 'SuppressWarnings': class file for edu.umd.cs.findbugs.annotations.SuppressWarnings not found
/Users/calavera/oss/ladle/lib/ladle/apacheds/apacheds-service-2.0.0-M15.jar(org/apache/directory/api/ldap/model/name/Dn.class): warning: Cannot find annotation method 'justification()' in type 'SuppressWarnings'
Note: lib/ladle/java/net/detailedbalance/ladle/Server.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
2 warnings
/opt/boxen/rbenv/versions/2.1.0-github1/bin/ruby -S rspec spec/ladle/server_spec.rb spec/ladle/version_spec.rb
.......................................................

Finished in 2 minutes 9.3 seconds
55 examples, 0 failures

[calavera]

I've also remove the java sources from the gem. They are not necessary.

[calavera]

This is what the data tarball looks like now:

tar zxvf data.tar.gz
x ASL20-LICENSE
x CHANGELOG.md
x CUSTOM-SCHEMA.md
x LICENSE
x NOTICE
x README.md
x lib/ladle.rb
x lib/ladle/apacheds/antlr-2.7.6.jar
x lib/ladle/apacheds/apacheds-service-2.0.0-M15.jar
x lib/ladle/apacheds/backport-util-concurrent-2.2.jar
x lib/ladle/apacheds/commons-cli-1.0.jar
x lib/ladle/apacheds/commons-collections-3.2.jar
x lib/ladle/apacheds/commons-io-1.4.jar
x lib/ladle/apacheds/commons-lang-2.1.jar
x lib/ladle/apacheds/jcl-over-slf4j-1.5.6.jar
x lib/ladle/apacheds/jdbm-1.0.jar
x lib/ladle/apacheds/log4j-1.2.14.jar
x lib/ladle/apacheds/mina-core-1.0.2.jar
x lib/ladle/apacheds/mina-filter-ssl-1.0.2.jar
x lib/ladle/apacheds/shared-asn1-0.9.5.5.jar
x lib/ladle/apacheds/shared-asn1-codec-0.9.5.5.jar
x lib/ladle/apacheds/shared-ldap-0.9.5.5.jar
x lib/ladle/apacheds/slf4j-api-1.5.6.jar
x lib/ladle/apacheds/spring-beans-1.2.8.jar
x lib/ladle/apacheds/spring-context-1.2.8.jar
x lib/ladle/apacheds/spring-core-1.2.8.jar
x lib/ladle/apacheds/xercesImpl-2.0.2.jar
x lib/ladle/default.ldif
x lib/ladle/java/net/detailedbalance/ladle/LadleFatalException.class
x lib/ladle/java/net/detailedbalance/ladle/Main$1.class
x lib/ladle/java/net/detailedbalance/ladle/Main.class
x lib/ladle/java/net/detailedbalance/ladle/Server.class
x lib/ladle/jruby_process.rb
x lib/ladle/ruby_process.rb
x lib/ladle/server.rb
x lib/ladle/version.rb
x spec/ladle/animals-custom-schema.ldif
x spec/ladle/animals-custom.ldif
x spec/ladle/animals.ldif
x spec/ladle/server_spec.rb
x spec/ladle/version_spec.rb
x spec/spec_helper.rb

[calavera]

@rsutphin it looks like Apache Directory needs more time to boot in this version. Do you want me to increase the timeout for the tests to see if they pass on travis?

[calavera]

@rsutphin I'm curious about what made you move to a super old version of AD here:

e377860

I can definitely boot the ldap server via ladle with this changes, but it looks like my tests don't pass when Net::LDAP tries to execute queries on the server.

[rsutphin]

Do you want me to increase the timeout for the tests to see if they pass on travis?

Yes, please give that a shot.

@rsutphin I'm curious about what made you move to a super old version of AD here:

Unfortunately I don't remember any more detail than what's in the commit message: something about ApacheDS 1.5 didn't work with the then-current version of net-ldap. Since net-ldap did work with my production system, I just switched to 1.0 to have something that I could usefully test with.

I'd be surprised if it's the same problem today — IIRC, net-ldap had at least a couple of major revisions since then.

[rsutphin]

Thanks for tracking down the logging issue, BTW.

[calavera]

I've increased the timeout to see what we get.

I solved my problem with Net::LDAP by removing the option to ignore server capabilities, we had it on by default for search.

[calavera]

@rsutphin I'm just fighting with travis, I don't really know how to fix the problem there. So far, I haven't seen any of those errors in my environment.

The latest build passes on ruby 2.1 and jruby, which for me is enough.

[rsutphin]

@calavera, thanks for all your work. #18 took this the last bit to completion.