Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify launch arguments for ease of editing #2

Closed
NUROISEA opened this issue Feb 17, 2023 · 0 comments
Closed

Unify launch arguments for ease of editing #2

NUROISEA opened this issue Feb 17, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@NUROISEA
Copy link
Owner

NUROISEA commented Feb 17, 2023

Problem

When changing a launch parameter all of the notebooks are modified. I don't want that because I'm too lazy for this.

Solution

Why not utilize configs/utility.py for this?

Change

args = [
  "--xformers [...]",
  # more stuff
]

to

args = [
  utility.default_args,
  # more stuff
]

and add the parameters in the configs/utility.py instead.

# configs/utility.py
default_args = "--xformers [...]"

But since adding more arguments will make the code scroll horizontally, why not do this instead:

#configs/utility.py
_args_array = [
  "--xformers",
  "--lowram",
  # more args
]

default_args = " ".join(_args_array)
@NUROISEA NUROISEA added the enhancement New feature or request label Feb 17, 2023
@NUROISEA NUROISEA self-assigned this Feb 17, 2023
@NUROISEA NUROISEA changed the title Prevent multiple file changes when changing params Unify launch arguments for ease of editing Feb 17, 2023
NUROISEA added a commit that referenced this issue Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant