feat: in scan mode, migrate addToHistory() calls to the queue handlers #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
csmig
added a commit
to csmig/stigman-watcher
that referenced
this pull request
Mar 4, 2024
commit f08e187 Author: csmig <33138761+csmig@users.noreply.github.com> Date: Thu Feb 29 18:58:21 2024 +0000 chore: remove/update dependencies (NUWCDIVNPT#97) commit a70d38a Author: csmig <33138761+csmig@users.noreply.github.com> Date: Thu Feb 22 19:41:45 2024 +0000 feat: in scan mode, migrate addToHistory() calls to the queue handlers (NUWCDIVNPT#93) Co-authored-by: matte22 <mferreira1264@gmail.com> commit d007792 Author: Mathew <77069472+Matte22@users.noreply.github.com> Date: Thu Feb 22 13:28:34 2024 -0500 test: Create Workflow for unit testing. (NUWCDIVNPT#92) commit e398da9 Author: Mathew <77069472+Matte22@users.noreply.github.com> Date: Mon Feb 19 17:57:22 2024 -0500 feat: scan mode history management (NUWCDIVNPT#90) commit 00f497f Author: csmig <33138761+csmig@users.noreply.github.com> Date: Fri Feb 16 15:37:43 2024 +0000 feat: pass filename to parsers as sourceRef (NUWCDIVNPT#91)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #62
This PR changes the scan mode logic for inserting newly discovered files into the historySet. The legacy logic added files into the historySet as soon as the scan function detected them. The updated code adds files later in the processing pipeline and only when the following conditions occur:
--create-objectsisfalse.The PR also updates the unit tests for the history management features.