Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comments to motion messages #312

Merged
merged 45 commits into from Aug 14, 2021
Merged

Conversation

KipHamiltons
Copy link
Member

Tell me if I should add a different reviewer.
Most of this is probably wrong of course.

shared/message/motion/KickCommand.proto Outdated Show resolved Hide resolved
shared/message/motion/KickCommand.proto Show resolved Hide resolved
shared/message/motion/KinematicsModel.proto Outdated Show resolved Hide resolved
shared/message/motion/KinematicsModel.proto Outdated Show resolved Hide resolved
shared/message/motion/KinematicsModel.proto Outdated Show resolved Hide resolved
@KipHamiltons KipHamiltons added the -Documentation Relating to documentation label Apr 30, 2021
@KipHamiltons KipHamiltons added G-Motion Motion Group L-Protobuf Uses or involves Protobuf labels Jul 14, 2021
shared/message/motion/KickCommand.proto Outdated Show resolved Hide resolved
shared/message/motion/KickCommand.proto Show resolved Hide resolved
shared/message/motion/KickCommand.proto Show resolved Hide resolved
shared/message/motion/KinematicsModel.proto Outdated Show resolved Hide resolved
shared/message/motion/ServoTarget.proto Outdated Show resolved Hide resolved
shared/message/motion/WalkCommand.proto Outdated Show resolved Hide resolved
shared/message/motion/WalkCommand.proto Outdated Show resolved Hide resolved
shared/message/motion/WalkCommand.proto Outdated Show resolved Hide resolved
@CMurtagh-LGTM CMurtagh-LGTM self-requested a review July 21, 2021 10:53
@KipHamiltons
Copy link
Member Author

@Bidski can I please grab a review on this one

Copy link
Contributor

@Bidski Bidski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@KipHamiltons KipHamiltons merged commit a6f58c7 into master Aug 14, 2021
@KipHamiltons KipHamiltons deleted the hamiltons/document_proto/motion branch August 14, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Documentation Relating to documentation G-Motion Motion Group L-Protobuf Uses or involves Protobuf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants