Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR (RO-2394) Language support for all components #91

Merged
merged 15 commits into from Aug 23, 2023
Merged

PR (RO-2394) Language support for all components #91

merged 15 commits into from Aug 23, 2023

Conversation

joergenlampe
Copy link
Contributor

Child components uses language from prop if prop is sent to the components. If not, they use language from DOM.

gruble
gruble requested changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@gruble gruble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se mine kommentarer til #90, de gjelder like mye her.
Du har også gjort samme endringer i date-utils og locale.ts i #90 som her, så spørs om ikke du ryker på en konflikt.

src/components/varsom-avalanche-activity-obs/varsom-avalanche-activity-obs.tsx Outdated Show resolved Hide resolved
gruble
gruble requested changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@gruble gruble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blir spennende å se om du får til å laste tekster i render-metoden.

src/components/varsom-avalanche-activity-obs/varsom-avalanche-activity-obs.tsx Outdated Show resolved Hide resolved
src/components/varsom-avalanche-activity-obs/varsom-avalanche-activity-obs.tsx Outdated Show resolved Hide resolved
gruble
gruble requested changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@gruble gruble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Koden har blitt mye enklere nå. Bra!

  • Tror jeg la inn en kommentar i koden.

  • Jeg tror også du mangler referanse til en del ledetekster i språkfila for ulykke/hendelse:
    image

  • Sjekk også linting. Jeg fikk noen advarsler på ubrukte variable eller importer.

src/components/varsom-observation/varsom-observation.tsx Outdated Show resolved Hide resolved
gruble
gruble approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@gruble gruble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette ble bra

@joergenlampe joergenlampe merged commit c0092b7 into main Aug 23, 2023
@joergenlampe joergenlampe deleted the feature_lang_support_for_all_components branch August 23, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruble gruble gruble approved these changes

@jorgkv jorgkv Awaiting requested review from jorgkv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joergenlampe @gruble