-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register Ops based on TRT version. #324
Closed
SrivastavaKshitij
wants to merge
20
commits into
NVIDIA-AI-IOT:master
from
SrivastavaKshitij:new_trt_ops
Closed
Register Ops based on TRT version. #324
SrivastavaKshitij
wants to merge
20
commits into
NVIDIA-AI-IOT:master
from
SrivastavaKshitij:new_trt_ops
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SrivastavaKshitij, Thanks for the PR, this is great! It's awesome to see it tested against so many different configurations. I'm going to quickly verify this against my machine configurations as well. Hope to get back shortly. Best, |
Yes, #307 is the reason because I couldn't get older versions to build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @jaybdub :
This PR helps registering ops based on TRT version. This PR supersedes #249 , #157 and #307
I have been working on making sure that TRT5 , TRT6 and TRT7 are compatible.
I have used three Pytorch NGC containers for experiments
With my current implementation, I had no trouble with
TRT 5
andTRT 6
. Unit Tests work well.However, I could not build torch2trt with
TRT7
as I got the error:So I modified my current implementation by taking your PR #307 and building my PR on top of it. Thats why commits from #307 are present in this PR
Now,
TRT6
andTRT7
works and unit tests are working absolutely fine. However,TRT5
is breaking during build time as #307 works withPytorch 1.3+
Right now , we have two issues.
[UPDATE]: It works for TRT 5 as well.
Will have to deprecate support for older Pytorch versions
I created a custom docker image:
Unit tests work fine.