Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Support runtime setting to embedding vector dimension #65

Closed
zehuanw opened this issue Nov 15, 2022 · 1 comment
Closed

[Feature Request] Support runtime setting to embedding vector dimension #65

zehuanw opened this issue Nov 15, 2022 · 1 comment

Comments

@zehuanw
Copy link
Collaborator

zehuanw commented Nov 15, 2022 •
edited by rhdong

It's inconvenient to the users if they need to recompile HKV to use new embedding vector size. On the other hand, if we list all the possible vector size in compile time will make our binary very big.

Shall we consider to support runtime setting to embedding vector dimension?

#65 (comment)
@rhdong rhdong closed this as completed Nov 15, 2022
@rhdong rhdong reopened this Nov 15, 2022
@rhdong
Copy link
Member

rhdong commented Jan 30, 2023 •
edited

This feature request has been merged in #87, thank you!

@rhdong rhdong closed this as completed Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhdong @zehuanw