Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RMP] Enable users to pass embedding tables directly into the input block in order to more easily support new functionality (non-trainable embeddings, different dimensions, model parallel, etc) #479

Closed
2 of 4 tasks
gabrielspmoreira opened this issue Jul 25, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request roadmap S3 Functionality
Milestone

Comments

@gabrielspmoreira
Copy link
Member

gabrielspmoreira commented Jul 25, 2022

Problem:

Customers want to be able to create embeddings that support a wide variety of options. The InputBlock handles the selection of these features through arguments, however we're up to 18 arguments and it's only going to get worse.
By separating input block definition from embedding creation we can allow for a much more flexible set of embeddings support with a simpler API.
The RMP #404 introduced the InputBlockV2 and also the Embeddings function that allow the user to provide a custom block for embeddings or infer the embeddings tables and their cardinality from the schema, exposing new options like setting trainable=False for embeddings.
But those new blocks are still experimental, for not being used yet by Merlin Models high-level API and have much less tests than the previous InputBlock

Goal:

Starting Point:

Note:
non-trainable embeddings is the pre-trained embeddings

@gabrielspmoreira gabrielspmoreira added this to the Merlin 22.09 milestone Jul 25, 2022
@gabrielspmoreira gabrielspmoreira changed the title [RMP] Leverage InputBlockV2 and EmbeddingTable in higher-level API [RMP] Leverage InputBlockV2 and EmbeddingTable in higher-level API and expand testing Jul 25, 2022
@gabrielspmoreira gabrielspmoreira self-assigned this Jul 25, 2022
@gabrielspmoreira gabrielspmoreira added enhancement New feature or request S3 Functionality labels Jul 25, 2022
@EvenOldridge EvenOldridge changed the title [RMP] Leverage InputBlockV2 and EmbeddingTable in higher-level API and expand testing [Task] Leverage InputBlockV2 and EmbeddingTable in higher-level API and expand testing Jul 29, 2022
@gabrielspmoreira gabrielspmoreira changed the title [Task] Leverage InputBlockV2 and EmbeddingTable in higher-level API and expand testing [RMP] Leverage InputBlockV2 and EmbeddingTable in higher-level API and expand testing Aug 1, 2022
@EvenOldridge EvenOldridge changed the title [RMP] Leverage InputBlockV2 and EmbeddingTable in higher-level API and expand testing [RMP] Enable users to pass embedding tables directly into the input block in order to more easily support new functionality (non-trainable embeddings, different dimensions, model parallel, etc) Aug 3, 2022
@viswa-nvidia
Copy link

Note comment for NVIDIA-Merlin/models#605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request roadmap S3 Functionality
Projects
None yet
Development

No branches or pull requests

4 participants