remove transform parameter from loader #935
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #845
Goals β½
Remove
transform
parameter frommerlin.models.tf.Loader
.Implementation Details π§
The
transform
parameter was removed when we migrated the loader to use the dataloader package, in favor of dataloader'stransforms
(with an s). As a result, thetransform
parameter will not do anything even if it's used, and not removing it was a miss in the previous PR. This PR properly cleans up the unused parameter.Testing Details π
Existing tests.