Android platform support #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moraaar <moraaar@amazon.com>
Signed-off-by: moraaar <moraaar@amazon.com>
Signed-off-by: moraaar <moraaar@amazon.com>
Signed-off-by: moraaar <moraaar@amazon.com>
|
|
Signed-off-by: moraaar <moraaar@amazon.com>
This was referenced Dec 1, 2022
Signed-off-by: moraaar <moraaar@amazon.com>
…e libraries to be correctly named with the suffix _64, the same as all the other platforms. Signed-off-by: moraaar <moraaar@amazon.com>
lemonade-dm
reviewed
Dec 8, 2022
| @@ -76,15 +76,15 @@ struct MTorqueCurveProperty : public PxFixedSizeLookupTablePropertyInfo<PxVehicl | |||
| PX_PHYSX_CORE_API MTorqueCurveProperty(); | |||
| }; | |||
|
|
|||
| #if PX_CLANG | |||
| #if PX_LINUX && PX_CLANG | |||
There was a problem hiding this comment.
Should this check be !PX_ANDROID, since this code may be applicable for other supported clang platforms(MacOS and Switch)?
There was a problem hiding this comment.
All the other places in the code base doing ignored "-Wreserved-identifier" are using #if PX_LINUX && PX_CLANG, this was the only one not to, so for consistency I followed the same pattern. And all the platforms built correctly like this.
|
Android platform support has been submitted to the following PhysX fork where it will be maintained: https://github.com/o3de/PhysX For more details see the following discussion: #58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
android-arm64-v8aadded. Initial support focused on 64-bit arm8 architecture with NEON SIMD instructions.Out of Scope
The following points are considered out of scope, they can be added in the future:
Known Errors/Limitations
bin\UNKNOWN. To fix this nVidia has to modify the CMakeModules package it's downloaded from packman when building PhysX. The file that needs to be modified isGetCompilerAndPlatform.cmake, adding the following lines to theifcondition insideGetPlatformBinNamefunction:Testing
PX_GENERATE_STATIC_LIBRARIESset to both true and false. The right output binaries were generated inbin/android.arm64-v8ainstalltarget successfully. It generated the correct output for Android underinstall/android-29folder, only including necessary headers for Android.Open 3D Engine (O3DE)with an early integration branch. The following video shows O3DE running PhysX 5.1 on Android.https://user-images.githubusercontent.com/27999040/203624867-6ed19905-d0dc-4dfe-943a-46e584fd9983.mp4
Signed-off-by: moraaar moraaar@amazon.com