Add make check target that runs basic tests #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: proper dependencies for python tests. |
JanuszL
reviewed
Jun 27, 2019
dali/test/python/CMakeLists.txt
Outdated
| # limitations under the License. | ||
|
|
||
|
|
||
| set(DALI_PYTHON_NOSETESTS |
There was a problem hiding this comment.
It soon will be out of sync with L0_*, can we have one file where we keep those test and call it from L0_ and cmake?
mzient
reviewed
Jun 28, 2019
|
!build |
mzient
reviewed
Jun 28, 2019
| @@ -151,6 +151,10 @@ cuda_include_directories( | |||
| "${PROJECT_SOURCE_DIR}" | |||
| "${PROJECT_SOURCE_DIR}/include") | |||
|
|
|||
|
|
|||
| set(CHECK_TARGET "check") | |||
There was a problem hiding this comment.
Out of curiosity: why not "test"?
There was a problem hiding this comment.
I got inspired by https://clang.llvm.org/get_started.html where they have make check-clang.
I didn't want to call it test, because make test could also suggest the building of tests (which we control by BUILD_TEST CMake flag).
mzient
approved these changes
Jun 28, 2019
|
CI MESSAGE: [797539]: BUILD STARTED |
|
CI MESSAGE: [797539]: BUILD PASSED |
klecki
changed the title
JanuszL
reviewed
Jul 10, 2019
JanuszL
approved these changes
Jul 10, 2019
Separate subtargets make check-gtest # for C++ unit tests make check-python # runs L0_python_self_tests For python there is tree of targets: make check-python-nose # runs all nosetests from L0_python_self_test make check-python-nose-testname # to run specific test make check-python-test # runs all python something.py tests from L0_python_self_test make check-python-test-testname # to run specific test Does not modify user's environment by any installation Expects nose and required pip packages to be present Expects DALI_EXTRA_PATH to be set up Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
make check-python uses that to run tests Simplified targets to: check: check-gtest # only C++ gtest cases check-python # contents of L0_python-self-test/test_body.sh Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [809053]: BUILD STARTED |
|
CI MESSAGE: [809053]: BUILD PASSED |
haoxintong
pushed a commit
to haoxintong/DALI
that referenced
this pull request
Jul 16, 2019
`check` target runs gtest and python L0 unit tests. Does not modify user's environment by any installation Expects nose and required pip packages to be present Expects DALI_EXTRA_PATH to be set up Moved test running in qa/L0_python-self-test to separate file make check-python uses that to run tests check has two subtargets: check-gtest # only C++ gtest cases check-python # contents of L0_python-self-test/test_body.sh Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate subtargets
make check-gtest # for C++ unit tests
make check-python # runs L0_python_self_tests
make check # runs all check-* targets
Does not modify user's environment by any installation
Expects nose and required pip packages to be present
Expects DALI_EXTRA_PATH to be set up
Signed-off-by: Krzysztof Lecki klecki@nvidia.com