Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input & output TYPED_TEST #1133

Merged
merged 32 commits into from Aug 7, 2019
Merged

Input & output TYPED_TEST #1133

merged 32 commits into from Aug 7, 2019

Conversation

szalpal
Copy link
Member

@szalpal szalpal commented Aug 1, 2019

Why we need this PR?

Pick one

  • It adds new feature: Ability to test kernel, that has different input and output types

DO NOT MERGE BEFORE #1060

@szalpal
Copy link
Member Author

szalpal commented Aug 1, 2019

My autoformat messed up with code a little bit, I'll fix it before merging

klecki
klecki requested changes Aug 2, 2019
View reviewed changes
dali/kernels/test/kernel_test_utils.h Outdated Show resolved Hide resolved
klecki
klecki approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@klecki klecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise than formatting, I would note, that this produces Cartesian Product MyTestTypes x MyTestTypes. The rest is ok.

@szalpal
impl
29ebcc5 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
working
080708e 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
rename
4645334 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
lint
ea505e7 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
minor fixes
553333a 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
update
1fe9acb 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
review
80d8bd2 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
impl
d248c9e 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
working
20e6edb 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
first impl
64b5177 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
renames
2ecad1d 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
bricon op with roi
8104c8c 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
set up tests
6812fa3 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
working impl
1edc9a6 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
lint
75ded1f 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
wip
23c7e7d 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
remove file
233f88a 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
ready to review
6cea422 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
invalid roi
184f18e 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
handle rois
4062f5a 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
box support
4dd955a 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
remove redundant file
67ae582 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
apply review
1b4f77b 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
apply review 2
5097e23 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
rebase
970c92b 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
rebase
bf7abc8 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
build error fix
cfdbc03 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
Utility for input & output typed test
7090c1a 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
delete
c39773c 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
fix format
fda75ab 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
error msg
3feedb6 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal szalpal changed the title [DO NOT MERGE] Input & output TYPED_TEST Input & output TYPED_TEST Aug 2, 2019
jantonguirao
jantonguirao reviewed Aug 2, 2019
View reviewed changes
dali/kernels/test/kernel_test_utils.h Show resolved Hide resolved
dali/kernels/test/kernel_test_utils.h Outdated Show resolved Hide resolved
dali/kernels/test/kernel_test_utils.h Outdated Show resolved Hide resolved
@szalpal
review
6fca986 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
Copy link
Member Author

szalpal commented Aug 5, 2019

!build

@JanuszL JanuszL requested a review from mzient August 5, 2019 14:36
@JanuszL JanuszL mentioned this pull request Aug 5, 2019
Merged
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [842814]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [842814]: BUILD FAILED

@szalpal
Copy link
Member Author

szalpal commented Aug 6, 2019

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [844287]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [844287]: BUILD PASSED

@szalpal szalpal merged commit ba4c6c6 into NVIDIA:master Aug 7, 2019
@szalpal szalpal deleted the gtest_utils branch November 20, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jantonguirao jantonguirao jantonguirao approved these changes

@klecki klecki klecki approved these changes

@JanuszL JanuszL JanuszL approved these changes

@mzient mzient Awaiting requested review from mzient

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@szalpal @dali-automaton @jantonguirao @klecki @JanuszL