New warp example #1158

mzient · 2019-08-09T13:36:18Z

Why we need this PR?

Pick one

It adds an example (and a kind of test) for NewWarpAffine
It fixes outstanding issues in CPU Argument Inputs
It adds randomized angle to Rotate test

What happened in this PR?

What was changed, added, removed?

the warp affine example with parameters passed in GPU memory
the warp affine example with parameters passed as named input (yay!)
added concat_str to join values into one string without delimiters

Was this PR tested? How?

it is a test

Were docs and examples updated, if necessary?

it is a doc

JIRA TASK: [DALI-1010]

JanuszL · 2019-08-20T13:17:26Z

dali/pipeline/operators/displacement/warp_impl.h

+  const OpSpec &Spec() const { return this->spec_; }
+
+ private:
+  /// @defgroup WarpStaticType Dynamic to static type routing


Please adjust comments from /// -> /* */.

JanuszL · 2019-08-20T13:22:31Z

dali/pipeline/operators/displacement/warp_param_provider.h

+
+ protected:
+  inline cudaStream_t GetStream() const {
+    return ws_ && ws_->has_stream() ? ws_->stream() : 0;


You can use #1178

JanuszL · 2019-08-20T13:40:47Z

docs/examples/warp_gpu.ipynb

@@ -0,0 +1,164 @@
+{


If you want to make it a part of our example set please add more description why certain things are done.

mzient · 2019-10-28T17:03:35Z

!build

dali-automaton · 2019-10-28T17:05:12Z

CI MESSAGE: [964451]: BUILD STARTED

* matrix as GPU argument (GPU variant) and as named input (CPU variant) * different interpolation and border handling. * add `concat_str` as a shortcut for `make_string_delim("", ...) * minor fixes related to CPU ArgumentInputs Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>

mzient · 2019-10-28T17:08:47Z

!build

dali-automaton · 2019-10-28T17:10:09Z

CI MESSAGE: [964461]: BUILD STARTED

dali-automaton · 2019-10-28T20:13:18Z

CI MESSAGE: [964461]: BUILD PASSED

JanuszL · 2019-10-29T00:50:30Z

docs/examples/warp.ipynb

+    "db_folder = os.path.join(test_data_root, 'db', 'lmdb')\n",
+    "\n",
+    "def gen_transform(angle, zoom, dst_cx, dst_cy, src_cx, src_cy):\n",
+    "    t1 = np.array([[1, 0, -dst_cx], [0, 1, -dst_cy], [0, 0, 1]])\n",


Please reformat this matrices to make them more readable.

JanuszL · 2019-10-29T00:50:57Z

docs/examples/warp.ipynb

+    "    t2 = np.array([[1, 0, src_cx], [0, 1, src_cy], [0, 0, 1]])\n",
+    "    return (np.matmul(t2, np.matmul(r, t1)))[0:2,0:3]\n",
+    "\n",
+    "def gen_transforms(n, step):\n",


gen_transforms and gen_transform sounds very alike.

JanuszL · 2019-10-29T01:02:59Z

docs/examples/warp.ipynb

@@ -0,0 +1,172 @@
+{


Please add more narrative with the detailed description of what is happening here. Now it is not something we can call a tutorial.
You can also show how to achieve things that were not possible earlier, like Shear or Translate operator.
Also please add this notebook to our docs (update appropriate *.rst inside docs folder to include this file).

* Chance make_string to use empty delimiter by default. * Add `operator<<(ostream &, const TensorLayout&)` Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>

mzient · 2019-10-29T10:25:32Z

!build

dali-automaton · 2019-10-29T10:30:31Z

CI MESSAGE: [965949]: BUILD STARTED

dali-automaton · 2019-10-29T13:28:40Z

CI MESSAGE: [965949]: BUILD PASSED

szalpal · 2019-10-29T17:30:54Z

I'd like to request a change to make the example better. Here's the list of things in my opinion are lacking:

What actually is a Warp operation. And affine (yes, at least few words about it IMHO is necessary)
What is the test dataset we are using
What does it mean to define affine transform? (e.g. what type should it have? np.array? np.matrix?)
Why the pipeline is called HybridPipe?
Why we use CaffeReader in example about WarpAffine? Where's a caffe here?
Code indentation and comment formatting
What we actually expect to obtain from such pipeline?
The code in the last snippet is fujka. Can we refactor it? Like close some of this in functions with meaningful names or sth. This code is for everyone to see...
I guess not all the imports are necessary

Lastly, whole point of notebook is to use snippets + markdown descriptions. So I'd move in-code comments to the descriptions.

mzient · 2019-10-30T10:02:24Z

!build

dali-automaton · 2019-10-30T10:05:22Z

CI MESSAGE: [967690]: BUILD STARTED

mzient · 2019-10-30T11:00:32Z

!build

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>

dali-automaton · 2019-10-30T11:05:48Z

CI MESSAGE: [967754]: BUILD STARTED

dali-automaton · 2019-10-30T14:30:04Z

CI MESSAGE: [967754]: BUILD PASSED

mzient requested review from jantonguirao, szalpal, klecki, JanuszL and awolant August 9, 2019 13:36

JanuszL reviewed Aug 20, 2019

View reviewed changes

mzient force-pushed the NewWarpExample branch 3 times, most recently from 7b72325 to e652a13 Compare October 28, 2019 17:02

mzient requested a review from JanuszL October 28, 2019 17:03

mzient force-pushed the NewWarpExample branch from e652a13 to 65946b9 Compare October 28, 2019 17:05

JanuszL reviewed Oct 29, 2019

View reviewed changes

* Improve example notebook.

3f8d519

* Chance make_string to use empty delimiter by default. * Add `operator<<(ostream &, const TensorLayout&)` Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>

JanuszL approved these changes Oct 29, 2019

View reviewed changes

jantonguirao approved these changes Oct 29, 2019

View reviewed changes

mzient force-pushed the NewWarpExample branch from 0e32214 to 60105c7 Compare October 30, 2019 09:59

mzient force-pushed the NewWarpExample branch from 60105c7 to 13fa4ce Compare October 30, 2019 10:01

mzient force-pushed the NewWarpExample branch from 13fa4ce to 5d57662 Compare October 30, 2019 10:59

mzient force-pushed the NewWarpExample branch from 5d57662 to 29c1c55 Compare October 30, 2019 11:01

Improved example notebook.

fd45232

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>

mzient force-pushed the NewWarpExample branch from 29c1c55 to fd45232 Compare October 30, 2019 11:03

mzient merged commit b5afda9 into NVIDIA:master Oct 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New warp example #1158

New warp example #1158

mzient commented Aug 9, 2019 •

edited

Loading

JanuszL Aug 20, 2019

JanuszL Aug 20, 2019

JanuszL Aug 20, 2019

mzient commented Oct 28, 2019

dali-automaton commented Oct 28, 2019

mzient commented Oct 28, 2019

dali-automaton commented Oct 28, 2019

dali-automaton commented Oct 28, 2019

JanuszL Oct 29, 2019

JanuszL Oct 29, 2019

JanuszL Oct 29, 2019

mzient commented Oct 29, 2019

dali-automaton commented Oct 29, 2019

dali-automaton commented Oct 29, 2019

szalpal commented Oct 29, 2019 •

edited

Loading

mzient commented Oct 30, 2019

dali-automaton commented Oct 30, 2019

mzient commented Oct 30, 2019

dali-automaton commented Oct 30, 2019

dali-automaton commented Oct 30, 2019

New warp example #1158

New warp example #1158

Conversation

mzient commented Aug 9, 2019 • edited Loading

Why we need this PR?

What happened in this PR?

JanuszL Aug 20, 2019

Choose a reason for hiding this comment

JanuszL Aug 20, 2019

Choose a reason for hiding this comment

JanuszL Aug 20, 2019

Choose a reason for hiding this comment

mzient commented Oct 28, 2019

dali-automaton commented Oct 28, 2019

mzient commented Oct 28, 2019

dali-automaton commented Oct 28, 2019

dali-automaton commented Oct 28, 2019

JanuszL Oct 29, 2019

Choose a reason for hiding this comment

JanuszL Oct 29, 2019

Choose a reason for hiding this comment

JanuszL Oct 29, 2019

Choose a reason for hiding this comment

mzient commented Oct 29, 2019

dali-automaton commented Oct 29, 2019

dali-automaton commented Oct 29, 2019

szalpal commented Oct 29, 2019 • edited Loading

mzient commented Oct 30, 2019

dali-automaton commented Oct 30, 2019

mzient commented Oct 30, 2019

dali-automaton commented Oct 30, 2019

dali-automaton commented Oct 30, 2019

mzient commented Aug 9, 2019 •

edited

Loading

szalpal commented Oct 29, 2019 •

edited

Loading