Fix fp16 bug from #1129 and add fp16 test case #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Serge Panev <spanev@nvidia.com>
Kh4L
requested review from
jantonguirao,
szalpal,
klecki,
banasraf and
awolant
jantonguirao
approved these changes
Aug 12, 2019
|
!build |
|
CI MESSAGE: [852854]: BUILD STARTED |
banasraf
approved these changes
Aug 12, 2019
klecki
approved these changes
Aug 12, 2019
|
CI MESSAGE: [852854]: BUILD FAILED |
awolant
approved these changes
Aug 12, 2019
klecki
pushed a commit
that referenced
this pull request
Aug 12, 2019
Initializing member variable `OutputType padding_value = 0;` for `__half` in the host code produced wrong results. `padding_val` is now a fp32 that is casted to `OuputType` in the CUDA kernel Signed-off-by: Serge Panev <spanev@nvidia.com>
|
CI MESSAGE: [852854]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Serge Panev spanev@nvidia.com
Why we need this PR?
Initializing member variable
OutputType padding_value = 0;for __half in the host code produced wrong results.What happened in this PR?
padding_valis now a fp32 that is casted toOuputTypein the CUDA kernelstatic_cast<OutputType>(padding_value)The CUDA kernel changes
Adding a fp16 test case
JIRA TASK: [DALI-1011]