Linear Transformation kernel for CPU #1300
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| // Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #ifndef DALI_KERNELS_IMGPROC_POINTWISE_LINEAR_TRANSFORMATION_CPU_H_ | ||
| #define DALI_KERNELS_IMGPROC_POINTWISE_LINEAR_TRANSFORMATION_CPU_H_ | ||
|
|
||
| #include <vector> | ||
| #include <utility> | ||
| #include "dali/core/format.h" | ||
| #include "dali/core/convert.h" | ||
| #include "dali/core/geom/box.h" | ||
| #include "dali/kernels/common/block_setup.h" | ||
| #include "dali/kernels/imgproc/surface.h" | ||
| #include "dali/kernels/imgproc/roi.h" | ||
|
|
||
| namespace dali { | ||
| namespace kernels { | ||
|
|
||
| template <typename OutputType, typename InputType, int channels_out, int channels_in, int ndims> | ||
| class LinearTransformationCpu { | ||
| private: | ||
| static_assert(ndims == 3, "This kernel is currently implemented for 3 dims only"); | ||
| static constexpr int spatial_ndims_ = ndims - 1; | ||
| using Mat = ::dali::mat<channels_out, channels_in, float>; | ||
| using Vec = ::dali::vec<channels_out, float>; | ||
|
|
||
| public: | ||
| KernelRequirements Setup(KernelContext &context, const InTensorCPU<InputType, ndims> &in, | ||
| Mat tmatrix = Mat::eye(), Vec tvector = {}, | ||
| const Roi<spatial_ndims_> *roi = nullptr) { | ||
| DALI_ENFORCE(in.shape.shape.back() == channels_in, | ||
| "Unexpected number of channels. Number of channels in InTensorCPU has to match" | ||
| " the number of channels, that the kernel is instantiated with"); | ||
| DALI_ENFORCE(!roi || all_coords(roi->hi >= roi->lo), | ||
| make_string("Invalid ROI: it doesn't follow {lo, hi} convention. ", roi)); | ||
|
|
||
| auto adjusted_roi = AdjustRoi(roi, in.shape); | ||
| KernelRequirements req; | ||
| TensorListShape<ndims> output_shape({ShapeFromRoi(adjusted_roi, channels_out)}); | ||
| req.output_shapes = {std::move(output_shape)}; | ||
| return req; | ||
| } | ||
|
|
||
|
|
||
| void Run(KernelContext &context, const OutTensorCPU<OutputType, ndims> &out, | ||
| const InTensorCPU<InputType, ndims> &in, Mat tmatrix = Mat::eye(), Vec tvector = {}, | ||
| const Roi<spatial_ndims_> *roi = nullptr) { | ||
| auto adjusted_roi = AdjustRoi(roi, in.shape); | ||
| auto ptr = out.data; | ||
| auto in_width = in.shape[1]; | ||
|
|
||
| for (int y = adjusted_roi.lo.y; y < adjusted_roi.hi.y; y++) { | ||
| auto *row_ptr = &in.data[y * in_width * channels_in]; | ||
| for (int x = adjusted_roi.lo.x; x < adjusted_roi.hi.x; x++) { | ||
| vec<channels_in, float> v_in; | ||
| for (int k = 0; k < channels_in; k++) { | ||
|
There was a problem hiding this comment. Not really, cause what I silently did here is casting the There was a problem hiding this comment. Please remove this static cast, as it will silence warnings if something really stupid happens (e.g. someone runs it on a tensor of boolean values). |
||
| v_in[k] = row_ptr[channels_in * x + k]; | ||
| } | ||
| vec<channels_out> v_out = tmatrix * v_in + tvector; | ||
| for (int k = 0; k < channels_out; k++) { | ||
| *ptr++ = ConvertSat<OutputType>(v_out[k]); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| } // namespace kernels | ||
| } // namespace dali | ||
|
|
||
| #endif // DALI_KERNELS_IMGPROC_POINTWISE_LINEAR_TRANSFORMATION_CPU_H_ | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What else can it be? It looks like renaming John, Bob and Alice to JohnHuman, BobHumand and AliceHuman.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming test suites in a way, that it ends with
Testseems to be quite a common thing. Be aware, that for a test caseTEST(Mat, Constructor)gtest's macro-magic generates a classMat_Constructor. In no case such name implies, that this class is actually a test. I'd say it's a thing we could add to the code style#1330
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly oppose making it a requirement. While I may even agree upon this in case of something as short as "Mat", adding "Test" to all test names will just add noise and produce long strings in GTest output.