Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of BmpImage::PeekShapeImpl, including number of channels #1332

Merged
merged 7 commits into from Oct 14, 2019

Conversation

jantonguirao
Copy link
Contributor

Signed-off-by: Joaquin Anton janton@nvidia.com

Why we need this PR?

Pick one

  • It fixes a bug bug description
  • It adds new feature needed because why we need this feature
  • Refactoring to improve what

What happened in this PR?

  • Explain solution of the problem, new feature added.
  • What was changed, added, removed?
  • What is most important part that reviewers should focus on?
  • Was this PR tested? How?
  • Were docs and examples updated, if necessary?

JIRA TASK: [DALI-XXXX]

Copy link
Contributor

@JanuszL JanuszL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it deserves some test and additional test samples in DALI extra.

@jantonguirao jantonguirao changed the title Add complete implementation of BmpImage::PeekShapeImpl, including number of channels [WIP] Add complete implementation of BmpImage::PeekShapeImpl, including number of channels Oct 4, 2019
@jantonguirao jantonguirao changed the title [WIP] Add complete implementation of BmpImage::PeekShapeImpl, including number of channels Add complete implementation of BmpImage::PeekShapeImpl, including number of channels Oct 11, 2019
@jantonguirao jantonguirao force-pushed the bmp_number_of_channels branch 2 times, most recently from ad7a919 to e4e3e3d Compare October 11, 2019 11:28
@jantonguirao jantonguirao changed the title Add complete implementation of BmpImage::PeekShapeImpl, including number of channels Add implementation of BmpImage::PeekShapeImpl, including number of channels Oct 11, 2019
@jantonguirao
Copy link
Contributor Author

!build

@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [941274]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [941274]: BUILD FAILED

…ber of channels

Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [943493]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [943493]: BUILD PASSED

DALI_EXTRA_VERSION Outdated Show resolved Hide resolved
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao jantonguirao merged commit 8b86e5d into NVIDIA:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants