New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementation of BmpImage::PeekShapeImpl, including number of channels #1332
Merged
jantonguirao
merged 7 commits into
NVIDIA:master
from
jantonguirao:bmp_number_of_channels
Oct 14, 2019
Merged
Add implementation of BmpImage::PeekShapeImpl, including number of channels #1332
jantonguirao
merged 7 commits into
NVIDIA:master
from
jantonguirao:bmp_number_of_channels
Oct 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jantonguirao
force-pushed
the
bmp_number_of_channels
branch
from
October 3, 2019 11:24
7092f89
to
db63711
Compare
awolant
approved these changes
Oct 3, 2019
JanuszL
reviewed
Oct 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it deserves some test and additional test samples in DALI extra.
jantonguirao
changed the title
Add complete implementation of BmpImage::PeekShapeImpl, including number of channels
[WIP] Add complete implementation of BmpImage::PeekShapeImpl, including number of channels
Oct 4, 2019
jantonguirao
changed the title
[WIP] Add complete implementation of BmpImage::PeekShapeImpl, including number of channels
Add complete implementation of BmpImage::PeekShapeImpl, including number of channels
Oct 11, 2019
jantonguirao
force-pushed
the
bmp_number_of_channels
branch
2 times, most recently
from
October 11, 2019 11:28
ad7a919
to
e4e3e3d
Compare
jantonguirao
changed the title
Add complete implementation of BmpImage::PeekShapeImpl, including number of channels
Add implementation of BmpImage::PeekShapeImpl, including number of channels
Oct 11, 2019
!build |
JanuszL
reviewed
Oct 11, 2019
jantonguirao
force-pushed
the
bmp_number_of_channels
branch
from
October 11, 2019 15:51
33abebd
to
0687b4a
Compare
!build |
JanuszL
approved these changes
Oct 11, 2019
CI MESSAGE: [941274]: BUILD STARTED |
CI MESSAGE: [941274]: BUILD FAILED |
…ber of channels Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
bmp_number_of_channels
branch
from
October 14, 2019 07:19
0687b4a
to
6ac07ba
Compare
!build |
CI MESSAGE: [943493]: BUILD STARTED |
CI MESSAGE: [943493]: BUILD PASSED |
jantonguirao
commented
Oct 14, 2019
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
bmp_number_of_channels
branch
from
October 14, 2019 11:52
f3eca4b
to
bac34ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
Pick one
What happened in this PR?
JIRA TASK: [DALI-XXXX]