Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support float16 in Cast GPU operator #1368

Merged
merged 3 commits into from
Oct 14, 2019
Merged

Support float16 in Cast GPU operator #1368

merged 3 commits into from
Oct 14, 2019

Conversation

jantonguirao
Copy link
Contributor

Why we need this PR?

Pick one

  • Cast GPU operator didn't support float16

What happened in this PR?

  • Added specialization of ConverterBase for OutputType=float16 to overcome the lack of __half constructor for types like int64_t
  • Added support for float16 in Cast GPU operator
  • Adjusted Cast operator to use ConvertSat utility
  • Fixed order of template arguments in Cast Op

JIRA TASK: [DALI-XXXX]

@jantonguirao
Enable float16 in Cast GPU operator
bf1d82d 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Adjust cast cpu to use ConvertSat as well
1f0e19c 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Copy link
Contributor Author

!build

@jantonguirao jantonguirao changed the title Cast gpu float16 Support float16 in Cast GPU operator Oct 11, 2019
JanuszL
JanuszL reviewed Oct 11, 2019
View reviewed changes
Copy link
Contributor

@JanuszL JanuszL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have test for that as well?

@jantonguirao
Add Cast tests for float16
250d033 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Copy link
Contributor Author

Can we have test for that as well?

Done

@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [941245]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [941245]: BUILD PASSED

@jantonguirao jantonguirao merged commit 9fe29a8 into NVIDIA:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanuszL JanuszL JanuszL approved these changes

@awolant awolant awolant approved these changes

@szalpal szalpal Awaiting requested review from szalpal

@mzient mzient Awaiting requested review from mzient

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jantonguirao @dali-automaton @JanuszL @awolant