Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DALI library modularization #1384

Merged
merged 8 commits into from
Oct 18, 2019
Merged

DALI library modularization #1384

merged 8 commits into from
Oct 18, 2019

Conversation

jantonguirao
Copy link
Contributor

@jantonguirao jantonguirao commented Oct 15, 2019 •
edited
Loading

Signed-off-by: Joaquin Anton janton@nvidia.com

Why we need this PR?

  • Need to modularize libdali in order to be flexible with different use cases (e.g. link with kernels only)

What happened in this PR?

  • Separated dali library into core, kernel, dali, and operator
  • Created stand alone test binaries for each library

JIRA TASK: DALI-108[6-9]

@jantonguirao jantonguirao force-pushed the dali_lib_modularization2 branch 2 times, most recently from 40837df to d58f742 Compare October 15, 2019 14:46
This was referenced Oct 15, 2019
Closed
Closed
@jantonguirao jantonguirao force-pushed the dali_lib_modularization2 branch 3 times, most recently from a0f5cb9 to f76d0cf Compare October 15, 2019 14:53
@jantonguirao jantonguirao changed the title [WIP] DALI library modularization DALI library modularization Oct 15, 2019
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [945580]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [945580]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [945696]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [945696]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [946855]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [946855]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [946963]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [946963]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [947167]: BUILD STARTED

mzient
mzient reviewed Oct 16, 2019
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@jantonguirao jantonguirao force-pushed the dali_lib_modularization2 branch 2 times, most recently from ccf78ea to 11dbda9 Compare October 16, 2019 14:07
mzient
mzient approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@mzient mzient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a sanity check, I'd try to run this in a bunch of DLFW containers.

@jantonguirao
Copy link
Contributor Author

As a sanity check, I'd try to run this in a bunch of DLFW containers.

I'll run L3 once the review is finished

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [947296]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [947296]: BUILD PASSED

@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [948955]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [948955]: BUILD FAILED

klecki
klecki requested changes Oct 17, 2019
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
dali/operators/geometric/CMakeLists.txt Show resolved Hide resolved
dali/kernels/CMakeLists.txt Outdated Show resolved Hide resolved
dali/kernels/CMakeLists.txt Outdated Show resolved Hide resolved
dali/kernels/alloc.h Show resolved Hide resolved
dali/python/CMakeLists.txt Show resolved Hide resolved
klecki
klecki approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@klecki klecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only a small thing, that the "check_gtest" is a magic string appearing in two places. Otherwise ok.

@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [949160]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [949322]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [949322]: BUILD FAILED

@jantonguirao
DALI library modularization
c63e3aa 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Revert copy_with_stride to be a part of python_function dir
bd40138 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Linking python function to operators lib (for copy_with_stride)
bb23b9b 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Code review fixes
d56de68 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Add linebreaks at the end of CMakeLists.txt files
3018138 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Code review fixes
2d87e26 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Move copy_with_stride to main dali lib
5e2e081 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [950459]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [950459]: BUILD FAILED

@jantonguirao
AddParent to be last thing in schema registration
7ee98bf 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [950518]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [950518]: BUILD PASSED

@jantonguirao jantonguirao merged commit 2f78cf8 into NVIDIA:master Oct 18, 2019
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2643895]: BUILD FAILED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzient mzient mzient approved these changes

@klecki klecki klecki approved these changes

@JanuszL JanuszL Awaiting requested review from JanuszL

@banasraf banasraf Awaiting requested review from banasraf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jantonguirao @dali-automaton @klecki @mzient