Rotate operator using Warp kernel #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
mzient
changed the title
|
CI MESSAGE: [951222]: BUILD STARTED |
|
CI MESSAGE: [951222]: BUILD FAILED |
- use AffineMapping - calculate output canvas size New: - Rotate operator - RotateParamProvider Changes: - add AdjustParams to WarpParamProvider - factor out WarpAttr schema - add deg/rad conversion to math_util Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
…at the augmentations really did. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
…center. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
!build |
Add comments to augmentation gallery. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
CI MESSAGE: [955335]: BUILD STARTED |
mzient
changed the title
| R"code(Counterclockwise rotation angle, in degrees.)code", DALI_FLOAT, true) | ||
| .InputLayout(0, "HWC") | ||
| .AddParent("DisplacementFilter"); | ||
| .DocStr(R"code(Apply an affine transformation to the image.)code") |
There was a problem hiding this comment.
Something more specific about Rotate?
| " input_type: ", itype, | ||
| " output_type: ", otype) | ||
| cv_pipeline = CVPipeline(batch_size, otype, itype, output_size); | ||
| cv_pipeline.build(); |
There was a problem hiding this comment.
build() will be invoked in compare_pipelines so you don't need to call it here
| for batch_size in [1, 4, 19]: | ||
| for output_size in [None, (160,240)]: | ||
| for (itype, otype) in io_types: | ||
| print("Testing cpu vs cv", |
There was a problem hiding this comment.
If you use yield you'll get a print of the parameters automatically
| " input type: ", itype, | ||
| " output type: ", otype) | ||
| cpu_pipeline = RotatePipeline("cpu", batch_size, otype, itype, output_size); | ||
| cpu_pipeline.build(); |
| #include "dali/core/format.h" | ||
|
|
||
| namespace dali { | ||
| namespace rotate_impl { |
There was a problem hiding this comment.
Suggested change
| namespace rotate_impl { | |
| namespace rotate { | |
| namespace impl { |
maybe?
There was a problem hiding this comment.
A shy 'no'? I don't think that level of nesting is necessary.
There was a problem hiding this comment.
As a matter of fact, I'll remove this namespace and have the using directives in the function that needs them.
|
CI MESSAGE: [955335]: BUILD FAILED |
Fix review issues. Reorganize tests. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
!build |
jantonguirao
approved these changes
Oct 22, 2019
|
CI MESSAGE: [955504]: BUILD STARTED |
|
CI MESSAGE: [955504]: BUILD PASSED |
awolant
approved these changes
Oct 23, 2019
rbetz
pushed a commit
to rbetz/DALI
that referenced
this pull request
Oct 28, 2019
* Breaking (?) changes: - `Rotate` now calculates output size to fit the rotated image *by default* - Interpolation method now defaults to INTERP_LINEAR * New Rotate operator based on Warp operator base: - use AffineMapping - infer output size * Remove old Rotate * Remove CropMirrorNormalize from augmentation_gallery - it obscured what the augmentations really did. * Remove Rotate test from `test_pipeline.py` * Add standalone rotate python test with OpenCV reference Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Zientkiewicz michalz@nvidia.com
Why we need this PR?
What happened in this PR?
JIRA TASK: [DALI-1095]